test cleanup

Author: dsessler7

internal/controller/postgrescluster/snapshots_test.go

@@ -153,15 +153,17 @@ func TestReconcileVolumeSnapshots(t *testing.T) {
 			},
 			DeletionPolicy: "Delete",
 		}
-		err := r.Client.Create(ctx, volumeSnapshotClass)
-		assert.NilError(t, err)
+		assert.NilError(t, r.Client.Create(ctx, volumeSnapshotClass))
+		t.Cleanup(func() { assert.Check(t, r.Client.Delete(ctx, volumeSnapshotClass)) })
 
 		// Create a cluster with snapshots enabled
 		cluster := testCluster()
 		cluster.Namespace = ns.Name
 		cluster.Spec.Backups.Snapshots = &v1beta1.VolumeSnapshots{
 			VolumeSnapshotClassName: volumeSnapshotClassName,
 		}
+		assert.NilError(t, r.Client.Create(ctx, cluster))
+		t.Cleanup(func() { assert.Check(t, r.Client.Delete(ctx, cluster)) })
 
 		// Create pvc for reconcile
 		pvc := &corev1.PersistentVolumeClaim{
@@ -188,15 +190,26 @@ func TestReconcileVolumeSnapshots(t *testing.T) {
 	})
 
 	t.Run("SnapshotsEnabledReadySnapshotsExist", func(t *testing.T) {
-		// volumeSnapshotClass still exists
+		// Create a volume snapshot class
+		volumeSnapshotClassName := "my-snapshotclass"
+		volumeSnapshotClass := &volumesnapshotv1.VolumeSnapshotClass{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: volumeSnapshotClassName,
+			},
+			DeletionPolicy: "Delete",
+		}
+		assert.NilError(t, r.Client.Create(ctx, volumeSnapshotClass))
+		t.Cleanup(func() { assert.Check(t, r.Client.Delete(ctx, volumeSnapshotClass)) })
+
 		// Create a cluster with snapshots enabled
 		cluster := testCluster()
 		cluster.Namespace = ns.Name
 		cluster.ObjectMeta.UID = "the-uid-123"
-		volumeSnapshotClassName := "my-snapshotclass"
 		cluster.Spec.Backups.Snapshots = &v1beta1.VolumeSnapshots{
 			VolumeSnapshotClassName: volumeSnapshotClassName,
 		}
+		assert.NilError(t, r.Client.Create(ctx, cluster))
+		t.Cleanup(func() { assert.Check(t, r.Client.Delete(ctx, cluster)) })
 
 		// Create pvc with annotation
 		pvcName := initialize.String("dedicated-snapshot-volume")
@@ -301,15 +314,26 @@ func TestReconcileVolumeSnapshots(t *testing.T) {
 	})
 
 	t.Run("SnapshotsEnabledCreateSnapshot", func(t *testing.T) {
-		// volumeSnapshotClass still exists
+		// Create a volume snapshot class
+		volumeSnapshotClassName := "my-snapshotclass"
+		volumeSnapshotClass := &volumesnapshotv1.VolumeSnapshotClass{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: volumeSnapshotClassName,
+			},
+			DeletionPolicy: "Delete",
+		}
+		assert.NilError(t, r.Client.Create(ctx, volumeSnapshotClass))
+		t.Cleanup(func() { assert.Check(t, r.Client.Delete(ctx, volumeSnapshotClass)) })
+
 		// Create a cluster with snapshots enabled
 		cluster := testCluster()
 		cluster.Namespace = ns.Name
 		cluster.ObjectMeta.UID = "the-uid-123"
-		volumeSnapshotClassName := "my-snapshotclass"
 		cluster.Spec.Backups.Snapshots = &v1beta1.VolumeSnapshots{
 			VolumeSnapshotClassName: volumeSnapshotClassName,
 		}
+		assert.NilError(t, r.Client.Create(ctx, cluster))
+		t.Cleanup(func() { assert.Check(t, r.Client.Delete(ctx, cluster)) })
 
 		// Create pvc with annotation
 		pvcName := initialize.String("dedicated-snapshot-volume")
@@ -840,7 +864,7 @@ func TestGetDedicatedSnapshotVolumeRestoreJob(t *testing.T) {
 func TestGetLatestCompleteBackupJob(t *testing.T) {
 	ctx := context.Background()
 	_, cc := setupKubernetes(t)
-	require.ParallelCapacity(t, 1)
+	// require.ParallelCapacity(t, 1)
 
 	r := &Reconciler{
 		Client: cc,