Validate pg_upgrade versions at the API server

Author: cbandy

config/crd/bases/postgres-operator.crunchydata.com_pgupgrades.yaml

@@ -1155,6 +1155,7 @@ spec:
             - toPostgresVersion
             type: object
             x-kubernetes-validations:
+            - rule: self.fromPostgresVersion < self.toPostgresVersion
             - message: Only Copy or Link before PostgreSQL 12
               rule: '!has(self.transferMethod) || (self.toPostgresVersion < 12 ? self.transferMethod
                 in ["Copy","Link"] : true)'

internal/controller/pgupgrade/pgupgrade_controller.go

@@ -153,6 +153,7 @@ func (r *PGUpgradeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 	setStatusToProgressingIfReasonWas("", upgrade)
 
 	// The "from" version must be smaller than the "to" version.
+	// NOTE: CRD validation also rejects these values.
 	// An invalid PGUpgrade should not be requeued.
 	if upgrade.Spec.FromPostgresVersion >= upgrade.Spec.ToPostgresVersion {
 

pkg/apis/postgres-operator.crunchydata.com/v1beta1/pgupgrade_types.go

@@ -76,6 +76,7 @@ type PGUpgradeSpec struct {
 // Arguments and settings for the pg_upgrade tool.
 // See: https://www.postgresql.org/docs/current/pgupgrade.html
 // ---
+// +kubebuilder:validation:XValidation:rule=`self.fromPostgresVersion < self.toPostgresVersion`
 // +kubebuilder:validation:XValidation:rule=`!has(self.transferMethod) || (self.toPostgresVersion < 12 ? self.transferMethod in ["Copy","Link"] : true)`,message="Only Copy or Link before PostgreSQL 12"
 // +kubebuilder:validation:XValidation:rule=`!has(self.transferMethod) || (self.toPostgresVersion < 17 ? self.transferMethod in ["Clone","Copy","Link"] : true)`,message="Only Clone, Copy, or Link before PostgreSQL 17"
 type PGUpgradeSettings struct {