Mass replaces all sprintf with safer snprintf equivalents to get rid of deprecation warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.

Author: solodon4

cocos/2d/CCFontAtlasCache.cpp

@@ -181,7 +181,7 @@ FontAtlas* FontAtlasCache::getFontAtlasCharMap(const std::string& plistFile)
 FontAtlas* FontAtlasCache::getFontAtlasCharMap(Texture2D* texture, int itemWidth, int itemHeight, int startCharMap)
 {
     char key[ATLAS_MAP_KEY_PREFIX_BUFFER_SIZE];
-    sprintf(key,"name:%p_%d_%d_%d",texture->getBackendTexture(),itemWidth,itemHeight,startCharMap);
+    snprintf(key, sizeof(key),"name:%p_%d_%d_%d",texture->getBackendTexture(),itemWidth,itemHeight,startCharMap);
     std::string atlasName = key;
 
     auto it = _atlasMap.find(atlasName);

cocos/2d/CCLabel.cpp

@@ -2334,7 +2334,7 @@ void Label::updateColor()
 std::string Label::getDescription() const
 {
     char tmp[50];
-    sprintf(tmp, "<Label | Tag = %d, Label = >", _tag);
+    snprintf(tmp, sizeof(tmp), "<Label | Tag = %d, Label = >", _tag);
     std::string ret = tmp;
     ret += _utf8Text;
 

cocos/2d/CCSprite.cpp

@@ -125,7 +125,7 @@ Sprite* Sprite::createWithSpriteFrameName(const std::string& spriteFrameName)
 
 #if COCOS2D_DEBUG > 0
     char msg[256] = {0};
-    sprintf(msg, "Invalid spriteFrameName: %s", spriteFrameName.c_str());
+    snprintf(msg, sizeof(msg), "Invalid spriteFrameName: %s", spriteFrameName.c_str());
     CCASSERT(frame != nullptr, msg);
 #endif
 
@@ -1730,9 +1730,9 @@ std::string Sprite::getDescription() const
 {
     char textureDescriptor[100];
     if (_renderMode == RenderMode::QUAD_BATCHNODE)
-        sprintf(textureDescriptor, "<Sprite | Tag = %d, TextureID = %p>", _tag, _batchNode->getTextureAtlas()->getTexture()->getBackendTexture());
+        snprintf(textureDescriptor, sizeof(textureDescriptor), "<Sprite | Tag = %d, TextureID = %p>", _tag, _batchNode->getTextureAtlas()->getTexture()->getBackendTexture());
     else
-        sprintf(textureDescriptor, "<Sprite | Tag = %d, TextureID = %p>", _tag, _texture->getBackendTexture());
+        snprintf(textureDescriptor, sizeof(textureDescriptor), "<Sprite | Tag = %d, TextureID = %p>", _tag, _texture->getBackendTexture());
 
     return textureDescriptor;
 }

cocos/3d/CCBundle3D.cpp

@@ -236,7 +236,7 @@ bool Bundle3D::loadObj(MeshDatas& meshdatas, MaterialDatas& materialdatas, NodeD
             tex.wrapS = backend::SamplerAddressMode::CLAMP_TO_EDGE;
             tex.wrapT = backend::SamplerAddressMode::CLAMP_TO_EDGE;
 
-            sprintf(str, "%d", ++i);
+            snprintf(str, sizeof(str), "%d", ++i);
             materialdata.textures.push_back(tex);
             materialdata.id = str;
             material.name = str;
@@ -308,7 +308,7 @@ bool Bundle3D::loadObj(MeshDatas& meshdatas, MaterialDatas& materialdatas, NodeD
             for (auto& submesh : subMeshMap) {
                 meshdata->subMeshIndices.push_back(submesh.second);
                 meshdata->subMeshAABB.push_back(calculateAABB(meshdata->vertex, meshdata->getPerVertexSize(), submesh.second));
-                sprintf(str, "%d", ++i);
+                snprintf(str, sizeof(str), "%d", ++i);
                 meshdata->subMeshIds.push_back(str);
 
                 auto modelnode = new (std::nothrow) ModelData();
@@ -1103,7 +1103,7 @@ bool Bundle3D::loadBinary(const std::string& path)
     }
 
     char version[20] = {0};
-    sprintf(version, "%d.%d", ver[0], ver[1]);
+    snprintf(version, sizeof(version), "%d.%d", ver[0], ver[1]);
     _version = version;
 
     // Read ref table size

cocos/3d/CCTerrain.cpp

@@ -841,7 +841,7 @@ void Terrain::cacheUniformAttribLocation()
         for (int i = 0; i < _maxDetailMapValue; ++i)
         {
             char str[20];
-            sprintf(str, "u_texture%d", i);
+            snprintf(str, sizeof(str), "u_texture%d", i);
             _detailMapLocation[i] = _programState->getUniformLocation(str);
         }
 

cocos/base/CCConsole.cpp

@@ -1242,17 +1242,17 @@ void Console::commandProjection(int fd, const std::string& /*args*/)
     auto proj = director->getProjection();
     switch (proj) {
         case cocos2d::Director::Projection::_2D:
-            sprintf(buf,"2d");
+            snprintf(buf, sizeof(buf),"2d");
             break;
         case cocos2d::Director::Projection::_3D:
-            sprintf(buf,"3d");
+            snprintf(buf, sizeof(buf),"3d");
             break;
         case cocos2d::Director::Projection::CUSTOM:
-            sprintf(buf,"custom");
+            snprintf(buf, sizeof(buf),"custom");
             break;
 
         default:
-            sprintf(buf,"unknown");
+            snprintf(buf, sizeof(buf),"unknown");
             break;
     }
     Console::Utility::mydprintf(fd, "Current projection: %s\n", buf);

cocos/base/CCDirector.cpp

@@ -1180,7 +1180,7 @@ void Director::showStats()
         // to make the FPS stable
         if (_accumDt > CC_DIRECTOR_STATS_INTERVAL)
         {
-            sprintf(buffer, "%.1f / %.3f", _frames / _accumDt, _secondsPerFrame);
+            snprintf(buffer, sizeof(buffer), "%.1f / %.3f", _frames / _accumDt, _secondsPerFrame);
             _FPSLabel->setString(buffer);
             _accumDt = 0;
             _frames = 0;
@@ -1189,13 +1189,13 @@ void Director::showStats()
         auto currentCalls = (unsigned long)_renderer->getDrawnBatches();
         auto currentVerts = (unsigned long)_renderer->getDrawnVertices();
         if( currentCalls != prevCalls ) {
-            sprintf(buffer, "GL calls:%6lu", currentCalls);
+            snprintf(buffer, sizeof(buffer), "GL calls:%6lu", currentCalls);
             _drawnBatchesLabel->setString(buffer);
             prevCalls = currentCalls;
         }
 
         if( currentVerts != prevVerts) {
-            sprintf(buffer, "GL verts:%6lu", currentVerts);
+            snprintf(buffer, sizeof(buffer), "GL verts:%6lu", currentVerts);
             _drawnVerticesLabel->setString(buffer);
             prevVerts = currentVerts;
         }

cocos/base/CCProfiling.cpp

@@ -115,7 +115,7 @@ std::string ProfilingTimer::getDescription() const
 {
     static char s_description[512] = {0};
 
-    sprintf(s_description, "%s ::\tavg1: %ldu,\tavg2: %ldu,\tmin: %ldu,\tmax: %ldu,\ttotal: %.2fs,\tnr calls: %ld", _nameStr.c_str(), _averageTime1, _averageTime2, minTime, maxTime, totalTime/1000000., numberOfCalls);
+    snprintf(s_description, sizeof(s_description), "%s ::\tavg1: %ldu,\tavg2: %ldu,\tmin: %ldu,\tmax: %ldu,\ttotal: %.2fs,\tnr calls: %ld", _nameStr.c_str(), _averageTime1, _averageTime2, minTime, maxTime, totalTime/1000000., numberOfCalls);
     return s_description;
 }
 

cocos/base/CCUserDefault.cpp

@@ -371,7 +371,7 @@ void UserDefault::setIntegerForKey(const char* pKey, int value)
     // format the value
     char tmp[50];
     memset(tmp, 0, 50);
-    sprintf(tmp, "%d", value);
+    snprintf(tmp, sizeof(tmp), "%d", value);
 
     setValueForKey(pKey, tmp);
 }
@@ -392,7 +392,7 @@ void UserDefault::setDoubleForKey(const char* pKey, double value)
     // format the value
     char tmp[50];
     memset(tmp, 0, 50);
-    sprintf(tmp, "%f", value);
+    snprintf(tmp, sizeof(tmp), "%f", value);
 
     setValueForKey(pKey, tmp);
 }

cocos/editor-support/cocostudio/TriggerBase.cpp

@@ -32,7 +32,7 @@ using namespace cocostudio;
 void sendEvent(unsigned int event)
 {
     char buf[10];
-    sprintf(buf, "%d", event);
+    snprintf(buf, sizeof(buf), "%d", event);
     std::string custom_event_name(buf);
 
     EventCustom eventCustom(custom_event_name);