Skip to content

Commit 025e6f8

Browse files
refactor: move config to another file
1 parent 326b94b commit 025e6f8

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

lib/src/web/countly_flutter_plugin.dart

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@ import 'dart:js_util';
88
import 'package:countly_flutter/countly_flutter.dart' as cly;
99
import 'package:countly_flutter/src/web/countly_sdk_web_interop.dart';
1010
import 'package:countly_flutter/src/web/json_interop.dart';
11+
import 'package:countly_flutter/src/web/plugin_config.dart';
1112
import 'package:flutter/services.dart';
1213
import 'package:flutter_web_plugins/flutter_web_plugins.dart';
1314

1415
class CountlyFlutterPlugin {
15-
static const String TAG = "CountlyFlutterPlugin";
16-
static const String COUNTLY_FLUTTER_SDK_VERSION_STRING = "24.11.2";
17-
static const String COUNTLY_FLUTTER_SDK_NAME = "dart-flutterb-web";
1816
List<Map<Object?, Object?>> retrievedWidgetList = [];
1917
MethodChannel? methodChannel;
2018

@@ -340,7 +338,7 @@ class CountlyFlutterPlugin {
340338
final head = querySelector('head');
341339

342340
// try this as module
343-
final scriptTag = _createScriptTag('https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/24.11.0/countly.min.js');
341+
final scriptTag = _createScriptTag(CountlyFlutterPluginConfig.WEB_SDK_URL);
344342
head?.children.add(scriptTag);
345343
await scriptTag.onLoad.first;
346344

@@ -573,8 +571,8 @@ class CountlyFlutterPlugin {
573571
Map<String, dynamic> configMap = {
574572
'app_key': config['appKey'],
575573
'url': config['serverURL'],
576-
'sdk_name': COUNTLY_FLUTTER_SDK_NAME,
577-
'sdk_version': COUNTLY_FLUTTER_SDK_VERSION_STRING,
574+
'sdk_name': CountlyFlutterPluginConfig.SDK_NAME,
575+
'sdk_version': CountlyFlutterPluginConfig.SDK_VERSION_STRING,
578576
'debug': config['loggingEnabled'],
579577
'session_update': config['sessionUpdateTimerDelay'],
580578
'max_events': config['eventQueueSizeThreshold'],

lib/src/web/plugin_config.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
class CountlyFlutterPluginConfig {
2+
static const String SDK_VERSION_STRING = '24.11.2';
3+
static const String SDK_NAME = 'dart-flutterb-web';
4+
static const String WEB_SDK_URL = 'https://cdnjs.cloudflare.com/ajax/libs/countly-sdk-web/24.11.0/countly.min.js';
5+
}

0 commit comments

Comments
 (0)