Skip to content

Conversation

@rondlh
Copy link
Contributor

@rondlh rondlh commented Dec 5, 2025

Use threading to download assets to speedup startup

Reference: #100

Use threading to download assets to speedup startup
@rondlh rondlh marked this pull request as draft December 5, 2025 00:32
@rondlh
Copy link
Contributor Author

rondlh commented Dec 5, 2025

This PR improves startup speed for me significantly. I'm not sure if this will cause issues for new user.
I noticed that if I change any assets while CaDoodle is running that this is detected and changes are reflected immediately.

@madhephaestus
Copy link
Member

the reason this is done as a blocking operation is because the resources in those repos are necessary for further processing. they need to be fully cloned (and when it is the first run of a version or is source it updates the repos.

While this would speed startup, it needs to be blocking.

@rondlh
Copy link
Contributor Author

rondlh commented Dec 5, 2025

the reason this is done as a blocking operation is because the resources in those repos are necessary for further processing. they need to be fully cloned (and when it is the first run of a version or is source it updates the repos.

While this would speed startup, it needs to be blocking.

OK, I guessed so already, but do they need to be blocking every time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants