Skip to content

Commit 67c0007

Browse files
committed
Merge branch 'development'
2 parents 5f19a00 + d4e89d3 commit 67c0007

File tree

16 files changed

+303
-124
lines changed

16 files changed

+303
-124
lines changed

.travis.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ notifications:
77

88
env:
99
global:
10-
- COLDBOX_VERSION=5.1.1
10+
- COLDBOX_VERSION=5.1.2
1111
matrix:
1212
- ENGINE=lucee@4.5 ANT_TARGET=build.all
1313
- ENGINE=lucee@5 ANT_TARGET=run-tests
1414
- ENGINE=adobe@11 ANT_TARGET=run-tests
1515
- ENGINE=adobe@2016 ANT_TARGET=run-tests
16-
#- ENGINE=@ortus/adobe-aether COLDBOX_VERSION=5.0.0 ANT_TARGET=run-tests ENGINENAME=adobe-aether
16+
#- ENGINE=adobe@2018 ANT_TARGET=run-tests
1717

1818
branches:
1919
only:
@@ -33,15 +33,11 @@ addons:
3333

3434
before_install:
3535
# CommandBox Keys
36-
- sudo apt-key adv --keyserver keys.gnupg.net --recv 6DA70622
36+
- curl -fsSl https://downloads.ortussolutions.com/debs/gpg | sudo apt-key add -
3737
- sudo echo "deb http://downloads.ortussolutions.com/debs/noarch /" | sudo tee -a
3838
/etc/apt/sources.list.d/commandbox.list
3939

4040
install:
41-
# Install CommandBox
42-
#- sudo bash -c "$(curl -fsSL https://commandbox.stg.ortushq.com/install.sh)" 4.0.0
43-
# Make CommandBox usable by travis user so I don't have to change anything
44-
#- sudo chmod 777 /usr/local/bin/box
4541
# Install Commandbox + Supporting Utilities
4642
- sudo apt-get update && sudo apt-get --assume-yes install commandbox haveged jq
4743
# Install dependencies

build/build.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
<!-- UPDATE ON EACH VERSION CYCLE -->
1212
<property name="groupID" value="ortussolutions" />
13-
14-
<property name="coldbox.version" value="5.1.1" />
15-
<property name="coldbox.stableversion" value="5.1.0" />
13+
14+
<property name="coldbox.version" value="5.1.2" />
15+
<property name="coldbox.stableversion" value="5.1.1" />
1616

1717
<property name="coldbox.slug" value="coldbox"/>
1818
<property name="cachebox.slug" value="cachebox"/>

server-adobe-aether.json renamed to server-adobe@2018.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"app":{
3-
"cfengine":"@ortus/adobe-aether"
3+
"cfengine":"adobe@2018"
44
},
5-
"name":"coldbox-adobe-aether",
5+
"name":"coldbox-adobe@2018",
66
"force":true,
77
"openBrowser":false,
88
"web":{

system/Bootstrap.cfc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,8 @@ component serializable="false" accessors="true"{
134134
application.fwReinit = true;
135135
// Verify if we are Reiniting?
136136
if( structkeyExists( application, appKey ) AND application[ appKey ].getColdboxInitiated() AND needReinit ){
137+
// Load Module CF Mappings so modules can unload properly
138+
application[ appKey ].getModuleService().loadMappings();
137139
// process preReinit interceptors
138140
application[ appKey ].getInterceptorService().processState( "preReinit" );
139141
// Shutdown the application services

system/FrameworkSupertype.cfc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,15 @@ component serializable="false" accessors="true"{
6868
} else {
6969
arguments.target = arguments.model;
7070
}
71-
71+
7272
// json?
7373
if( structKeyExists( arguments, "jsonstring" ) ){
7474
return wirebox.getObjectPopulator().populateFromJSON( argumentCollection=arguments );
7575
}
7676
// XML
7777
else if( structKeyExists( arguments, "xml" ) ){
7878
return wirebox.getObjectPopulator().populateFromXML( argumentCollection=arguments );
79-
}
79+
}
8080
// Query
8181
else if( structKeyExists( arguments, "qry" ) ){
8282
return wirebox.getObjectPopulator().populateFromQuery( argumentCollection=arguments );
@@ -432,7 +432,7 @@ component serializable="false" accessors="true"{
432432
* @asset The asset(s) to load, only js or css files. This can also be a comma delimmited list.
433433
*/
434434
string function addAsset( required asset ){
435-
return getInstance( "coldbox.system.core.dynamic.HTMLHelper" ).addAsset( argumentCollection=arguments );
435+
return getInstance( "@HTMLHelper" ).addAsset( argumentCollection=arguments );
436436
}
437437

438438
/**
@@ -463,7 +463,7 @@ component serializable="false" accessors="true"{
463463
} else if ( fileExists( UDFFullPath & ".cfm" ) ){
464464
targetLocation = "#udflibrary#.cfm";
465465
} else {
466-
throw(
466+
throw(
467467
message = "Error loading UDF library: #arguments.udflibrary#",
468468
detail = "The UDF library was not found. Please make sure you verify the file location.",
469469
type = "FrameworkSupertype.UDFLibraryNotFoundException");
Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
/**
2+
* Module Config
3+
*/
4+
component {
5+
6+
// Module Properties
7+
this.title = "HTML Helper";
8+
// Model Namespace
9+
this.modelNamespace = "HTMLHelper";
10+
// CF Mapping
11+
this.cfmapping = "HTMLHelper";
12+
// Auto-map models
13+
this.autoMapModels = true;
14+
// Module Dependencies
15+
this.dependencies = [];
16+
17+
function configure(){
18+
// module settings - stored in modules.name.settings
19+
settings = {
20+
// The base path of JS assets
21+
js_path = "",
22+
// The base path of CSS assets
23+
css_path = "",
24+
// Encode values on all dynamically generated tags in the HTML Helper
25+
encodeValues = false
26+
};
27+
28+
// Custom Declared Points
29+
interceptorSettings = {
30+
customInterceptionPoints = ""
31+
};
32+
33+
// Custom Declared Interceptors
34+
interceptors = [
35+
];
36+
37+
// Map HTML Helper to provide continuity from previous ColdBox apps
38+
binder.map( "HTMLHelper@coldbox" )
39+
.to( "#moduleMapping#.models.HTMLHelper" );
40+
41+
}
42+
43+
/**
44+
* Fired when the module is registered and activated.
45+
*/
46+
function onLoad(){
47+
}
48+
49+
/**
50+
* Fired when the module is unregistered and unloaded
51+
*/
52+
function onUnload(){
53+
54+
}
55+
56+
}

0 commit comments

Comments
 (0)