Skip to content

Commit 8421182

Browse files
author
Miguel Tomas
committed
**Fixed**:
- Fixed the issue where closing *UiPresenter* would be called after the game object is disabled
1 parent 0c846f9 commit 8421182

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

CHANGELOG.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,17 @@ All notable changes to this package will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
55
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html)
66

7-
## [0.7.1] - 2021-05-03
7+
## [0.7.2] - 2021-05-09
8+
9+
**Fixed**:
10+
- Fixed the issue where closing *UiPresenter* would be called after the game object is disabled
11+
12+
## [0.7.1] - 2021-05-03
813

914
- Added the possibility for *SafeAreaHelpersView* to maintain the View in the same position if not placed outside of the safe area
1015

1116
**Fixed**:
12-
- Fixed the duplicated memory issue when loading the same *UiPresenter* multiple times at the same time before when of them is finished
13-
17+
- Fixed the duplicated memory issue when loading the same *UiPresenter* multiple times at the same time before when of them is finished
1418

1519
## [0.7.0] - 2021-03-12
1620

Runtime/UiPresenter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ internal void InternalOpen()
5555

5656
internal virtual void InternalClose()
5757
{
58-
if (this != null && gameObject != null)
58+
OnClosed();
59+
if (gameObject != null)
5960
{
6061
gameObject.SetActive(false);
6162
}
62-
OnClosed();
6363
}
6464
}
6565

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "com.gamelovers.uiservice",
33
"displayName": "UiService",
4-
"version": "0.7.1",
4+
"version": "0.7.2",
55
"unity": "2020.3",
66
"description": "This package provides a service to help manage an Unity's, game UI.\nIt allows to open, close, load, unload and request any Ui Configured in the game.\nThe package provides a Ui Set that allows to group a set of Ui Presenters to help load, open and close multiple Uis at the same time.\n\nTo help configure the game's UI you need to create a UiConfigs Scriptable object by:\n- Right Click on the Project View > Create > ScriptableObjects > Configs > UiConfigs",
77
"dependencies": {

0 commit comments

Comments
 (0)