CB/revert: Do not use longtext but stay with text like gitea 1.15 for issues and comments

This disables migration v191 and prevents v198 from adding a longtext column
XORM struts are also reverted to TEXT to prevent warnings during starup

Author: ashimokawa

models/issue.go

@@ -42,7 +42,7 @@ type Issue struct {
 	OriginalAuthor   string
 	OriginalAuthorID int64      `xorm:"index"`
 	Title            string     `xorm:"name"`
-	Content          string     `xorm:"LONGTEXT"`
+	Content          string     `xorm:"TEXT"`
 	RenderedContent  string     `xorm:"-"`
 	Labels           []*Label   `xorm:"-"`
 	MilestoneID      int64      `xorm:"INDEX"`

models/issue_comment.go

@@ -228,12 +228,12 @@ type Comment struct {
 	CommitID        int64
 	Line            int64 // - previous line / + proposed line
 	TreePath        string
-	Content         string `xorm:"LONGTEXT"`
+	Content         string `xorm:"TEXT"`
 	RenderedContent string `xorm:"-"`
 
 	// Path represents the 4 lines of code cemented by this comment
 	Patch       string `xorm:"-"`
-	PatchQuoted string `xorm:"LONGTEXT patch"`
+	PatchQuoted string `xorm:"TEXT patch"`
 
 	CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
 	UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`

models/issues/content_history.go

@@ -23,7 +23,7 @@ type ContentHistory struct {
 	IssueID        int64              `xorm:"INDEX"`
 	CommentID      int64              `xorm:"INDEX"`
 	EditedUnix     timeutil.TimeStamp `xorm:"INDEX"`
-	ContentText    string             `xorm:"LONGTEXT"`
+	ContentText    string             `xorm:"TEXT"`
 	IsFirstCreated bool
 	IsDeleted      bool
 }

models/migrations/migrations.go

@@ -335,7 +335,7 @@ var migrations = []Migration{
 	// v190 -> v191
 	NewMigration("Add agit flow pull request support", addAgitFlowPullRequest),
 	// v191 -> v192
-	NewMigration("Alter issue/comment table TEXT fields to LONGTEXT", alterIssueAndCommentTextFieldsToLongText),
+	NewMigration("Alter issue/comment table TEXT fields to LONGTEXT (nop)", alterIssueAndCommentTextFieldsToLongText),
 	// v192 -> v193
 	NewMigration("RecreateIssueResourceIndexTable to have a primary key instead of an unique index", recreateIssueResourceIndexTable),
 	// v193 -> v194

models/migrations/v191.go

@@ -5,26 +5,10 @@
 package migrations
 
 import (
-	"code.gitea.io/gitea/modules/setting"
-
 	"xorm.io/xorm"
 )
 
 func alterIssueAndCommentTextFieldsToLongText(x *xorm.Engine) error {
 
-	sess := x.NewSession()
-	defer sess.Close()
-	if err := sess.Begin(); err != nil {
-		return err
-	}
-
-	if setting.Database.UseMySQL {
-		if _, err := sess.Exec("ALTER TABLE `issue` CHANGE `content` `content` LONGTEXT"); err != nil {
-			return err
-		}
-		if _, err := sess.Exec("ALTER TABLE `comment` CHANGE `content` `content` LONGTEXT, CHANGE `patch` `patch` LONGTEXT"); err != nil {
-			return err
-		}
-	}
-	return sess.Commit()
+	return nil
 }

models/migrations/v198.go

@@ -19,7 +19,7 @@ func addTableIssueContentHistory(x *xorm.Engine) error {
 		IssueID        int64              `xorm:"INDEX"`
 		CommentID      int64              `xorm:"INDEX"`
 		EditedUnix     timeutil.TimeStamp `xorm:"INDEX"`
-		ContentText    string             `xorm:"LONGTEXT"`
+		ContentText    string             `xorm:"TEXT"`
 		IsFirstCreated bool
 		IsDeleted      bool
 	}