feat(ui): allow directory selection and include all files recursively… #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
It seems like, at least on macOS, |
Owner
Author
|
Also, make directory handling code only available when building the ui target |
CodeF0x
commented
Dec 2, 2025
| >Most systems can handle 2. Increase for powerful computers. | ||
| Adding more threads does not automatically make your job | ||
| faster!</span | ||
| faster! Balance out for ffmpeg options accordingly.</span |
| const files: string[] | null = await open({ | ||
| multiple: true, | ||
| directory: false, | ||
| directory: true, |
Owner
Author
There was a problem hiding this comment.
what happens if you select multiple folders? will all files in those folder be added to the list?
| let logger = Arc::new(Logger::new(Arc::clone(&progress), app_handle.clone())); | ||
| let processor = Processor::new(Arc::clone(&logger), Arc::clone(&progress)); | ||
|
|
||
| println!("{:?}", paths); |
Comment on lines
+107
to
+112
| eprintln!("{}", error); | ||
|
|
||
| #[cfg(feature = "ui")] | ||
| { | ||
| let _ = app_handle.emit("file-list-error", error); | ||
| } |
Owner
Author
There was a problem hiding this comment.
No need to print the error to the console and no need to check if it's running in ui because it's always running in ui. This code will never get executed from the cli
Comment on lines
+120
to
+125
| eprintln!("{}", error); | ||
|
|
||
| #[cfg(feature = "ui")] | ||
| { | ||
| let _ = app_handle.emit("file-list-error", error); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #57