AboutView Animation Improvements #1915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AcknowledgementsView and ContributorsView now use a LazyVStack to improve performance
austincondiff
approved these changes
Oct 20, 2024
Collaborator
austincondiff
left a comment
austincondiff
left a comment
There was a problem hiding this comment.
I like the blur as the previous screen fades out. Great attention to detail!
austincondiff
requested review from
0xWDG,
FastestMolasses,
thecoolwinter and
tom-ludwig
FastestMolasses
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AboutView. For example,AcknowledgementsViewandContributorsViewnow use a LazyVStack to improve performance. A threshold was also added to the functiongetScrollAdjustedValue()to avoid unnecessary view updates.Related Issues
Checklist
Screenshots
Before
Screen.Recording.2024-10-18.at.3.31.19.PM.mov
After
Screen.Recording.2024-10-18.at.3.04.37.PM.mov