Skip to content

Commit 5879c14

Browse files
authored
BB2-3312: Updated ApplicationSerializer to swap support email for contacts. (#1236)
* Updated ApplicationSerializer to swap support email for contacts. Since support email is always what is expected, field name notwithstanding. * Remove print
1 parent 1f0537a commit 5879c14

File tree

2 files changed

+37
-0
lines changed

2 files changed

+37
-0
lines changed
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
from apps.test import BaseApiTest
2+
from ..views import ApplicationSerializer
3+
4+
5+
class TestApplicationSerializer(BaseApiTest):
6+
7+
def test_application_serializer(self):
8+
dev_user = self._create_user("developer_test", "123456")
9+
test_app = self._create_application(
10+
"test_app",
11+
user=dev_user,
12+
logo_uri="example.com/logo",
13+
tos_uri="example.com/tos",
14+
policy_uri="example.com/policy",
15+
contacts="contacts@example.com",
16+
support_email="support@example.com",
17+
)
18+
19+
serializer = ApplicationSerializer(test_app)
20+
serialized = serializer.data
21+
expected = {
22+
'id': 1,
23+
'name': 'test_app',
24+
'logo_uri': 'example.com/logo',
25+
'tos_uri': 'example.com/tos',
26+
'policy_uri': 'example.com/policy',
27+
'contacts': 'support@example.com'
28+
}
29+
30+
self.assertEqual(serialized, expected)

apps/authorization/views.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,17 @@
2424

2525

2626
class ApplicationSerializer(serializers.ModelSerializer):
27+
contacts = serializers.SerializerMethodField()
28+
2729
class Meta:
2830
model = Application
2931
fields = ('id', 'name', 'logo_uri', 'tos_uri', 'policy_uri', 'contacts')
3032

33+
def get_contacts(self, obj):
34+
print(obj)
35+
application = Application.objects.get(id=obj.id)
36+
return application.support_email or ""
37+
3138

3239
class DataAccessGrantSerializer(serializers.ModelSerializer):
3340
application = ApplicationSerializer(read_only=True)

0 commit comments

Comments
 (0)