Ensure v3 smart config uses the v3 logic, boost robustness if expected fields are missing. (#1358)

Author: jimmyfagan

apps/wellknown/views/openid.py

@@ -65,10 +65,10 @@ def smart_configuration_v3(request):
     data = build_smart_config_endpoint(data, issuer=issuer)
 
     # v3 specific info, very important since tokens aren't compatible between versions 1/2 and 3
-    data["authorization_endpoint"] = data["authorization_endpoint"].replace("/v2/o/", "/v3/o/")
-    data["revocation_endpoint"] = data["revocation_endpoint"].replace("/v2/o/", "/v3/o/")
-    data["token_endpoint"] = data["token_endpoint"].replace("/v2/o/", "/v3/o/")
-    data["fhir_metadata_uri"] = data["fhir_metadata_uri"].replace("/v2/fhir/", "/v3/fhir/")
+    data["authorization_endpoint"] = data.get("authorization_endpoint", "").replace("/v2/o/", "/v3/o/")
+    data["revocation_endpoint"] = data.get("revocation_endpoint", "").replace("/v2/o/", "/v3/o/")
+    data["token_endpoint"] = data.get("token_endpoint", "").replace("/v2/o/", "/v3/o/")
+    data["fhir_metadata_uri"] = data.get("fhir_metadata_uri", "").replace("/v2/fhir/", "/v3/fhir/")
 
     return JsonResponse(data)
 

hhs_oauth_server/urls.py

@@ -7,7 +7,7 @@
 
 from apps.accounts.views.oauth2_profile import openidconnect_userinfo
 from apps.fhir.bluebutton.views.home import fhir_conformance, fhir_conformance_v2
-from apps.wellknown.views.openid import smart_configuration
+from apps.wellknown.views.openid import smart_configuration, smart_configuration_v3
 from hhs_oauth_server.hhs_oauth_server_context import IsAppInstalled
 from .views import testobject
 
@@ -45,7 +45,7 @@ def robots_txt(request):
     path("v2/fhir/.well-known/smart-configuration", smart_configuration, name="smart_configuration"),
     path("v2/fhir/metadata", fhir_conformance_v2, name="fhir_conformance_metadata_v2"),
     path("v2/fhir/", include("apps.fhir.bluebutton.v2.urls")),
-    path("v3/fhir/.well-known/smart-configuration", smart_configuration, name="smart_configuration_v3"),
+    path("v3/fhir/.well-known/smart-configuration", smart_configuration_v3, name="smart_configuration_v3"),
     path("v3/fhir/metadata", fhir_conformance_v2, name="fhir_conformance_metadata_v3"),
     path("v3/fhir/", include("apps.fhir.bluebutton.v3.urls")),
     path("v2/o/", include("apps.dot_ext.v2.urls")),