fix: detailed error logs

Author: CM43210

package.json

@@ -2,7 +2,7 @@
   "name": "php-ecs-formatter",
   "displayName": "PHP ECS Formatter",
   "description": "Format, fix, and compare your PHP code using Easy Coding Standard (ECS) directly in Visual Studio Code",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "author": {
     "name": "Cezary Marcinik",
     "email": "cezary.marcinik@o2.pl"

src/core/ProcessRunner.ts

@@ -26,13 +26,17 @@ export class DefaultProcessRunner implements ProcessRunner {
           "--fix",
           `--config=${configPath}`,
           "--no-progress-bar",
-          "--quiet",
         ],
         { cwd: workspaceRoot }
       );
 
+      let stdoutData = "";
       let stderrData = "";
 
+      processHandle.stdout.on("data", (data) => {
+        stdoutData += data.toString();
+      });
+
       processHandle.stderr.on("data", (data) => {
         stderrData += data.toString();
       });
@@ -45,7 +49,13 @@ export class DefaultProcessRunner implements ProcessRunner {
         if (code === 0) {
           resolve();
         } else {
-          reject(new Error(`ECS exited with code ${code}\n${stderrData}`));
+          reject(
+            new Error(
+              `ECS exited with code ${code}\n` +
+                `STDERR:\n${stderrData}\n` +
+                `STDOUT:\n${stdoutData}`
+            )
+          );
         }
       });
     });

src/test/unit/core/ProcessRunner.test.ts

@@ -47,7 +47,6 @@ suite("DefaultProcessRunner", () => {
         "--fix",
         "--config=/path/to/ecs.php",
         "--no-progress-bar",
-        "--quiet",
       ],
       "Should pass correct arguments to ECS"
     );
@@ -88,21 +87,25 @@ suite("DefaultProcessRunner", () => {
     };
     spawnStub.returns(fakeChildProcess);
 
-    fakeChildProcess.on.withArgs("close").yields(1);
-
+    fakeChildProcess.stdout.on
+      .withArgs("data")
+      .callsArgWith(1, Buffer.from("Some ECS output"));
     fakeChildProcess.stderr.on
       .withArgs("data")
-      .callsArgWith(1, "Some ECS error");
+      .callsArgWith(1, Buffer.from("Some ECS error"));
+
+    fakeChildProcess.on.withArgs("close").yields(1);
 
     const runner = new DefaultProcessRunner();
+
     await assert.rejects(
       runner.runEcsCheck(
         "/path/to/ecs",
         "/path/to/ecs.php",
         "file.php",
         "/my/ws"
       ),
-      /ECS exited with code 1\nSome ECS error/
+      /ECS exited with code 1\nSTDERR:\nSome ECS error\nSTDOUT:\nSome ECS output/
     );
   });