Skip to content

Commit e254cf8

Browse files
committed
fix(72): Fix make-env command
When adding a new line in the requirements file, `cat ''` was used instead of `echo ""`. Parameter `add_specific_requirements` has been renamed to `add_specific_requirements_file` for that same command for clarity.
1 parent 2c636f4 commit e254cf8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.circleci/config.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ commands:
4545
type: string
4646
default: "7"
4747
description: "Pytest version to use for testing"
48-
add_specific_requirements:
48+
add_specific_requirements_file:
4949
type: string
5050
default: ""
5151
description: "Add specific requirements listed in a file to the environment. "
@@ -79,9 +79,9 @@ commands:
7979
echo $dep >> requirements.txt
8080
done
8181
fi
82-
cat "" >> requirements.txt
83-
if [ "<< parameters.add_specific_requirements >>" != "" ]; then
84-
cat "<< parameters.add_specific_requirements >>" >> requirements.txt
82+
echo "" >> requirements.txt
83+
if [ "<< parameters.add_specific_requirements_file >>" != "" ]; then
84+
cat "<< parameters.add_specific_requirements_file >>" >> requirements.txt
8585
fi
8686
- run:
8787
name: "Create environment"
@@ -222,7 +222,7 @@ jobs:
222222
docker: *image
223223
steps:
224224
- make-env:
225-
add_specific_requirements: requirements.dev.txt
225+
add_specific_requirements_file: requirements.dev.txt
226226
- lint-project
227227
build:
228228
docker: *image

0 commit comments

Comments
 (0)