Skip to content

Deprecate inherited batched helpers in the Splines #945

@tpadioleau

Description

@tpadioleau

Some functions like

template <
class BatchedInterpolationDDom,
class = std::enable_if_t<ddc::is_discrete_domain_v<BatchedInterpolationDDom>>>
explicit SplineBuilder(
BatchedInterpolationDDom const& batched_interpolation_domain,
std::optional<std::size_t> cols_per_chunk = std::nullopt,
std::optional<unsigned int> preconditioner_max_block_size = std::nullopt)
: SplineBuilder(
interpolation_domain_type(batched_interpolation_domain),
cols_per_chunk,
preconditioner_max_block_size)
{
}

are inherited from the previous implementation of the splines where the batched dimensions were in the class templates. As the batched dimensions are now only known during the transformation, these functions/aliases should no longer be necessary. A review over all builders and evaluators should be done.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions