Add 3D Splines (with periodic or greville boundary conditions) (#925)

* Add a 3D spline builder for the periodic case

* Changes to the derivs domain
- rename some of the type aliases
- use only one deriv dimension in the derivs_domain type aliases
- enable the greville tests
- lower the norm threshold for the triple derivative to 1e-10

* Reword the FIXMEs in the 3D test

* Fix a typo

* Format the splines CMakeLists.txt

* Add missing doc comments and add unused annotations to the derivs
parameters

* Declare new header files to CMake

* Increase timeout

* Modify 3D error bound computation

* Slightly increase tolerance

---------

Co-authored-by: Thomas Padioleau <thomas.padioleau@cea.fr>
Co-authored-by: Hariprasad Kannan <3788945+science-enthusiast@users.noreply.github.com>

Author: 3 people

.github/workflows/tests-ubuntu.yaml

@@ -345,7 +345,7 @@ jobs:
             cmake --build build
             if [ 'xcpu' = 'x${{matrix.backend.name}}' ]
             then
-              ctest --test-dir build --output-on-failure --timeout 10 --output-junit tests.xml
+              ctest --test-dir build --output-on-failure --timeout 20 --output-junit tests.xml
               cp build/tests.xml .
               ./build/examples/characteristics_advection
               ./build/examples/game_of_life
@@ -454,7 +454,7 @@ jobs:
               . /src/sanitizer_env.sh
             fi
 
-            ctest --test-dir build --output-on-failure --timeout 10 --output-junit tests.xml
+            ctest --test-dir build --output-on-failure --timeout 20 --output-junit tests.xml
             cp build/tests.xml .
             ./build/examples/characteristics_advection
             ./build/examples/game_of_life

CMakeLists.txt

@@ -282,8 +282,10 @@ if("${DDC_BUILD_KERNELS_SPLINES}")
                     include/ddc/kernels/splines/spline_boundary_conditions.hpp
                     include/ddc/kernels/splines/spline_builder.hpp
                     include/ddc/kernels/splines/spline_builder_2d.hpp
+                    include/ddc/kernels/splines/spline_builder_3d.hpp
                     include/ddc/kernels/splines/spline_evaluator.hpp
                     include/ddc/kernels/splines/spline_evaluator_2d.hpp
+                    include/ddc/kernels/splines/spline_evaluator_3d.hpp
                     include/ddc/kernels/splines/spline_traits.hpp
                     include/ddc/kernels/splines/splines_linear_problem.hpp
                     include/ddc/kernels/splines/splines_linear_problem_2x2_blocks.hpp

include/ddc/kernels/splines.hpp

@@ -18,8 +18,10 @@
 #include "splines/spline_boundary_conditions.hpp"
 #include "splines/spline_builder.hpp"
 #include "splines/spline_builder_2d.hpp"
+#include "splines/spline_builder_3d.hpp"
 #include "splines/spline_evaluator.hpp"
 #include "splines/spline_evaluator_2d.hpp"
+#include "splines/spline_evaluator_3d.hpp"
 #include "splines/spline_traits.hpp"
 #include "splines/splines_linear_problem.hpp"
 #include "splines/splines_linear_problem_2x2_blocks.hpp"

include/ddc/kernels/splines/spline_builder_3d.hpp

@@ -144,6 +144,26 @@ foreach(BC "BC_PERIODIC" "BC_GREVILLE" "BC_HERMITE")
     endforeach()
 endforeach()
 
+foreach(BC "BC_PERIODIC" "BC_GREVILLE") # "BC_HERMITE")
+    foreach(EVALUATOR "EVALUATOR_POLYNOMIAL")
+        foreach(DEGREE RANGE "${DDC_SPLINES_TEST_DEGREE_MIN}" "${DDC_SPLINES_TEST_DEGREE_MAX}")
+            foreach(BSPLINES_TYPE "BSPLINES_TYPE_UNIFORM" "BSPLINES_TYPE_NON_UNIFORM")
+                set(test_name
+                    "3d_splines_tests_BATCHED_DEGREE_${DEGREE}_${BSPLINES_TYPE}_${EVALUATOR}_${BC}"
+                )
+                add_executable("${test_name}" ../main.cpp batched_3d_spline_builder.cpp)
+                target_compile_definitions(
+                    "${test_name}"
+                    PUBLIC -DDEGREE=${DEGREE} -D${BSPLINES_TYPE} -D${EVALUATOR} -D${BC}
+                )
+                target_compile_features("${test_name}" PUBLIC cxx_std_17)
+                target_link_libraries("${test_name}" PUBLIC DDC::core DDC::splines GTest::gtest)
+                gtest_discover_tests("${test_name}" DISCOVERY_MODE PRE_TEST)
+            endforeach()
+        endforeach()
+    endforeach()
+endforeach()
+
 foreach(SOLVER "GINKGO" "LAPACK")
     foreach(BC "BC_PERIODIC" "BC_GREVILLE" "BC_HERMITE")
         foreach(DEGREE_X RANGE "${DDC_SPLINES_TEST_DEGREE_MIN}" "${DDC_SPLINES_TEST_DEGREE_MAX}")