Code cleanup and appimage fix

Author: BuddySirJava

.github/workflows/linux-appimage.yml

@@ -28,7 +28,7 @@ jobs:
             python3-gi \
             libgtksourceview-5-dev libgtk-4-dev libadwaita-1-dev libglib2.0-dev libpango1.0-dev pkg-config gobject-introspection
           python -m pip install --upgrade pip
-          python -m pip install --user "appimage-builder==0.8.2"
+          python -m pip install --user --upgrade "appimage-builder>=1.1.0"
           echo "$HOME/.local/bin" >> $GITHUB_PATH
       
       - name: Build and install blueprint-compiler (v0.18.0)
@@ -56,8 +56,6 @@ jobs:
 
       - name: Build AppImage
         run: |
-          export PATH="/usr/bin:$PATH"
-          export PYTHON="/usr/bin/python3"
           export ARCH=x86_64
           appimage-builder --recipe AppImageBuilder.yml --skip-test
 

src/main.py

@@ -17,8 +17,8 @@
 
 import gi
 import logging
-from gettext import gettext as _
 import gettext
+from gettext import gettext as _
 
 import threading
 
@@ -182,7 +182,6 @@ def do_startup(self):
             )
         except Exception:
             pass
-        self._add_actions()
 
         self.parser = SSHConfigParser()
         GLib.idle_add(self._parse_config_async)
@@ -219,31 +218,6 @@ def update_ui():
         t.start()
         return False
 
-    def _add_actions(self):
-        search_action = Gio.SimpleAction.new("search", None)
-        search_action.connect("activate", self._on_search_action)
-        self.add_action(search_action)
-
-        add_host_action = Gio.SimpleAction.new("add-host", None)
-        add_host_action.connect("activate", self._on_add_host_action)
-        self.add_action(add_host_action)
-
-        reload_action = Gio.SimpleAction.new("reload", None)
-        reload_action.connect("activate", self._on_reload_action)
-        self.add_action(reload_action)
-
-    def _on_search_action(self, action, param):
-        if self.main_window:
-            self.main_window._toggle_search()
-
-    def _on_add_host_action(self, action, param):
-        if self.main_window and self.main_window.host_list:
-            self.main_window.host_list.add_host()
-
-    def _on_reload_action(self, action, param):
-        if self.main_window:
-            self.main_window.reload_config()
-
     def _load_css_styles(self):
         css_provider = Gtk.CssProvider()
 

src/ui/host_editor.py

@@ -914,13 +914,13 @@ def _parse_and_validate_raw_text(self, current_lines: list[str]):
                     line.strip() and not line.strip().startswith("#")
                     for line in current_lines
                 ):
-                    self.app._show_error(
+                    self.app.show_toast(
                         "SSH host configuration must start with 'Host' declaration"
                     )
             else:
-                self.app._show_error(f"Invalid raw host configuration: {e}")
+                self.app.show_toast(f"Invalid raw host configuration: {e}")
         except Exception as e:
-            self.app._show_error(f"Error parsing raw host config: {e}")
+            self.app.show_toast(f"Error parsing raw host config: {e}")
 
     def _update_host_from_fields(self):
         """Updates the current host object based on GUI field values.
@@ -1603,7 +1603,7 @@ def _on_save_clicked(self, button):
                     parser.write(backup=True)
                 except Exception as e:
                     try:
-                        self.app._show_error(
+                        self.app.show_toast(
                             _(f"Failed to save {parser.config_path}: {e}")
                         )
                     except Exception:
@@ -1625,7 +1625,7 @@ def _on_save_clicked(self, button):
                             verify = None
                         if verify != expected_content:
                             try:
-                                self.app._show_error(
+                                self.app.show_toast(
                                     _(
                                         f"Failed to persist changes to {parser.config_path}. Check permissions / sandbox."
                                     )

src/ui/main_window.py

@@ -355,7 +355,7 @@ def _load_config(self):
             if hasattr(self.app, "_parse_config_async"):
                 self.app._parse_config_async()
         except Exception as e:
-            self._show_error(f"Failed to trigger config reload: {e}")
+            self.show_toast(f"Failed to trigger config reload: {e}")
 
     def _reselect_current_host(self):
         try:
@@ -493,9 +493,9 @@ def _on_save_clicked(self, button):
                 self.host_list.set_undo_enabled(False)
             except Exception:
                 pass
-            self._update_status(_("Configuration saved successfully"))
+            self.show_toast(_("Configuration saved successfully"))
         except Exception as e:
-            self._show_error(f"Failed to save configuration: {e}")
+            self.show_toast(f"Failed to save configuration: {e}")
 
     def _write_and_reload(self, show_status: bool = False):
         """Write the config to disk and reload UI without showing validation dialogs."""
@@ -511,9 +511,9 @@ def _write_and_reload(self, show_status: bool = False):
             except Exception:
                 pass
             if show_status:
-                self._update_status(_("Configuration saved"))
+                self.show_toast(_("Configuration saved"))
         except Exception as e:
-            self._show_error(f"Failed to save configuration: {e}")
+            self.show_toast(f"Failed to save configuration: {e}")
 
     def _on_host_selected(self, host_list, host):
         """Handle host selection from the list."""
@@ -811,7 +811,7 @@ def on_close_request(dlg):
                 pass
             if self.parser:
                 self._load_config()
-            self._update_status(_("Preferences saved"))
+            self.show_toast(_("Preferences saved"))
             return False
 
         dialog.connect("close-attempt", on_close_request)
@@ -860,18 +860,6 @@ def _on_about(self, action, param):
 
         about_window.present()
 
-    def _update_status(self, message: str):
-        """Update the status bar with a message."""
-        self.show_toast(message)
-
-    def _hide_status(self):
-        """Hide the status bar."""
-        return False
-
-    def _show_error(self, message: str):
-        """Show an error message in the status bar."""
-        self.show_toast(message)
-
     def _show_warning(self, title: str, message: str):
         """Show a warning dialog."""
         dialog = Gtk.MessageDialog(