fix: Python 3.8 compatibility for type hints #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `tuple[...]` to `Tuple[...]` in type hints for Python 3.8 compatibility. The lowercase generic syntax was introduced in Python 3.9 (PEP 585), but our CI runs on Python 3.8. Changes: - Added `Tuple` to typing imports - Changed return type annotation from `tuple[...]` to `Tuple[...]` Fixes CI test collection error: TypeError: 'type' object is not subscriptable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
tuple[...]toTuple[...]in type hints for Python 3.8 compatibility. The lowercase generic syntax was introduced in Python 3.9 (PEP 585), but our CI runs on Python 3.8.Changes:
Tupleto typing importstuple[...]toTuple[...]Fixes CI test collection error:
TypeError: 'type' object is not subscriptable