Merge branch 'dev'

Author: BlitzErik

Documentation/sp_Blitz Checks by Priority.md

@@ -6,8 +6,8 @@ Before adding a new check, make sure to add a Github issue for it first, and hav
 
 If you want to change anything about a check - the priority, finding, URL, or ID - open a Github issue first. The relevant scripts have to be updated too.
 
-CURRENT HIGH CHECKID: 211
-If you want to add a new one, start at 212
+CURRENT HIGH CHECKID: 212
+If you want to add a new one, start at 213
 
 | Priority | FindingsGroup | Finding | URL | CheckID |
 |----------|-----------------------------|---------------------------------------------------------|------------------------------------------------------------------------|----------|
@@ -283,5 +283,6 @@ If you want to add a new one, start at 212
 | 250 | Server Info | Virtual Server | https://www.BrentOzar.com/go/virtual | 103 |
 | 250 | Server Info | Windows Version |  | 172 |
 | 250 | Server Info | Power Plan |  | 211 |
+| 250 | Server Info | Stacked Instances | https://www.brentozar.com/go/babygotstacked/ | 212 |
 | 254 | Rundate | (Current Date) |  | 156 |
 | 255 | Thanks! | From Your Community Volunteers |  | -1 |

Install-All-Scripts.sql

@@ -28,8 +28,8 @@ SET NOCOUNT ON;
 BEGIN;
 
 DECLARE @Version VARCHAR(30);
-SET @Version = '2.1';
-SET @VersionDate = '20180101';
+SET @Version = '2.2';
+SET @VersionDate = '20180201';
 
 IF @Help = 1
 

Install-Core-Blitz-No-Query-Store.sql

@@ -35,8 +35,8 @@ SET NOCOUNT ON;
 BEGIN;
 
 DECLARE @Version VARCHAR(30);
-SET @Version = '2.1';
-SET @VersionDate = '20180101';
+SET @Version = '2.2';
+SET @VersionDate = '20180201';
 
 
 IF @Help = 1

Install-Core-Blitz-With-Query-Store.sql

@@ -32,8 +32,8 @@ AS
     SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 	DECLARE @Version VARCHAR(30);
-	SET @Version = '6.1';
-	SET @VersionDate = '20180101';
+	SET @Version = '6.2';
+	SET @VersionDate = '20180201';
 	SET @OutputType = UPPER(@OutputType);
 
 	IF @Help = 1 PRINT '
@@ -520,6 +520,16 @@ AS
 			  LoginName NVARCHAR(256) ,
 			  DBUserName NVARCHAR(256)
 			 );
+        
+        
+		IF OBJECT_ID('tempdb..#Instances') IS NOT NULL
+			DROP TABLE #Instances;
+		CREATE TABLE #Instances
+            (
+              Instance_Number NVARCHAR(MAX) ,
+              Instance_Name NVARCHAR(MAX) ,
+              Data_Field NVARCHAR(MAX)
+            );
 
 		IF OBJECT_ID('tempdb..#IgnorableWaits') IS NOT NULL
 			DROP TABLE #IgnorableWaits;
@@ -7186,7 +7196,42 @@ IF @ProductVersionMajor >= 10 AND  NOT EXISTS ( SELECT  1
 
 								END;
 
-							
+						IF NOT EXISTS ( SELECT  1
+										FROM    #SkipChecks
+										WHERE   DatabaseName IS NULL AND CheckID = 212 )
+								BEGIN																		
+								
+								IF @Debug IN (1, 2) RAISERROR('Running CheckId [%d].', 0, 1, 212) WITH NOWAIT;
+
+						        INSERT INTO #Instances (Instance_Number, Instance_Name, Data_Field)
+								EXEC master.sys.xp_regread @rootkey = 'HKEY_LOCAL_MACHINE',
+								                           @key = 'SOFTWARE\Microsoft\Microsoft SQL Server',
+								                           @value_name = 'InstalledInstances'
+								
+                                IF (SELECT COUNT(*) FROM #Instances) > 1
+                                BEGIN
+
+                                    DECLARE @InstanceCount NVARCHAR(MAX)
+                                    SELECT @InstanceCount = COUNT(*) FROM #Instances
+                                                              
+									INSERT INTO #BlitzResults
+										( 
+										  CheckID ,
+										  Priority ,
+										  FindingsGroup ,
+										  Finding ,
+										  URL ,
+										  Details
+										)							
+							        SELECT  
+									    212 AS CheckId ,
+									    250 AS Priority ,
+									    'Server Info' AS FindingsGroup ,
+									    'Instance Stacking' AS Finding ,
+									    'https://www.brentozar.com/go/babygotstacked/' AS URL ,
+									    'Your Server has ' + @InstanceCount + ' Instances of SQL Server running. More than one is usually a bad idea. Read the URL for more info'
+							    END;
+	                        END;
 
 							IF NOT EXISTS ( SELECT  1
 											FROM    #SkipChecks

sp_AllNightLog.sql

@@ -21,8 +21,8 @@ AS
     SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 	DECLARE @Version VARCHAR(30);
-	SET @Version = '2.1';
-	SET @VersionDate = '20180101';
+	SET @Version = '2.2';
+	SET @VersionDate = '20180201';
 
 	IF @Help = 1 PRINT '
 	/*