Merge pull request #2388 from BrentOzarULTD/2386_sp_BlitzFirst_stats_update_check

#2386 sp_BlitzFirst new check for stats

Author: BrentOzar

Documentation/sp_BlitzFirst_Checks_by_Priority.md

@@ -6,8 +6,8 @@ Before adding a new check, make sure to add a Github issue for it first, and hav
 
 If you want to change anything about a check - the priority, finding, URL, or ID - open a Github issue first. The relevant scripts have to be updated too.
 
-CURRENT HIGH CHECKID: 43
-If you want to add a new check, start at 44
+CURRENT HIGH CHECKID: 44
+If you want to add a new check, start at 45
 
 | Priority | FindingsGroup | Finding | URL | CheckID |
 |----------|---------------------------------|---------------------------------------|-------------------------------------------------|----------|
@@ -28,9 +28,10 @@ If you want to add a new check, start at 44
 | 40 | Table Problems | Forwarded Fetches/Sec High | https://BrentOzar.com/go/fetch | 29 |
 | 50 | In-Memory OLTP | Garbage Collection in Progress | https://BrentOzar.com/go/garbage | 31 |
 | 50 | Query Problems | Compilations/Sec High | https://BrentOzar.com/go/compile | 15 |
+| 50 | Query Problems | Implicit Transactions | https://www.brentozar.com/go/ImplicitTransactions/ | 37 |
 | 50 | Query Problems | Plan Cache Erased Recently | https://BrentOzar.com/go/freeproccache | 7 |
 | 50 | Query Problems | Re-Compilations/Sec High | https://BrentOzar.com/go/recompile | 16 |
-| 50 | Query Problems | ImplicitTransactions | https://www.brentozar.com/go/ImplicitTransactions/ | 37 |
+| 50 | Query Problems | Statistics Updated Recently | https://BrentOzar.com/go/stats | 44 |
 | 50 | Server Performance | High CPU Utilization | https://BrentOzar.com/go/cpu | 24 |
 | 50 | Server Performance | High CPU Utilization - Non SQL Processes | https://BrentOzar.com/go/cpu | 28 |
 | 50 | Server Performance | Page Life Expectancy Low | https://BrentOzar.com/go/ple | 10 |

sp_BlitzFirst.sql

@@ -2049,6 +2049,34 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
 
         END; /* IF @Seconds < 30 */
 
+
+    /* Query Problems - Statistics Updated Recently - CheckID 44 */
+	EXEC sp_MSforeachdb N'USE [?];
+	INSERT INTO #BlitzFirstResults (CheckID, Priority, FindingsGroup, Finding, URL, Details)
+	SELECT 44 AS CheckId,
+			50 AS Priority,
+			''Query Problems'' AS FindingGroup,
+			''Statistics Updated Recently'' AS Finding,
+			''http://www.BrentOzar.com/go/stats'' AS URL,
+			Details = 
+				QUOTENAME(DB_NAME()) + N''.'' +
+				QUOTENAME(SCHEMA_NAME(obj.schema_id)) + N''.'' +
+				QUOTENAME(obj.name) + NCHAR(13) + NCHAR(10) +
+				N''statistic '' + QUOTENAME(stat.name) + NCHAR(13) + NCHAR(10) +
+				N''was updated on '' + CONVERT(NVARCHAR(50), sp.last_updated, 121) + N'','' + NCHAR(13) + NCHAR(10) + 
+				N''had '' + CAST(sp.rows AS NVARCHAR(50)) + N'' rows, with '' +
+				CAST(sp.rows_sampled AS NVARCHAR(50)) + N'' rows sampled,'' +  NCHAR(13) + NCHAR(10) +
+				N''producing '' + CAST(sp.steps AS NVARCHAR(50)) + N'' steps in the histogram.'' +  NCHAR(13) + NCHAR(10) +
+				N''This invalidated plans in the cache for this object, causing plan compiles and parameter sniffing.''
+	FROM sys.objects AS obj   
+	INNER JOIN sys.stats AS stat ON stat.object_id = obj.object_id  
+	CROSS APPLY sys.dm_db_stats_properties(stat.object_id, stat.stats_id) AS sp  
+	WHERE sp.last_updated > DATEADD(MI, -15, GETDATE())
+	  AND obj.is_ms_shipped = 0
+	  AND ''[?]'' <> ''[tempdb]'';';
+
+
+
 	RAISERROR('Finished running investigatory queries',10,1) WITH NOWAIT;
 
 
@@ -3876,7 +3904,8 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
                         ELSE 0
                     END DESC,
                     Finding,
-                    ID;
+                    ID,
+					CAST(Details AS NVARCHAR(4000));
         END;
         ELSE IF @ExpertMode = 0 AND @OutputType <> 'NONE' AND @OutputXMLasNVARCHAR = 1 AND @SinceStartup = 0
         BEGIN
@@ -3897,7 +3926,8 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
                         ELSE 0
                     END DESC,
                     Finding,
-                    ID;
+                    ID,
+					CAST(Details AS NVARCHAR(4000));
         END;
         ELSE IF @ExpertMode = 1
         BEGIN
@@ -3955,7 +3985,8 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
                             ELSE 0
                         END DESC,
                         r.Finding,
-                        r.ID;
+                        r.ID,
+						CAST(r.Details AS NVARCHAR(4000));
 
             -------------------------
             --What happened: #WaitStats