Skip to content

Commit fce7190

Browse files
committed
Testing: Added PHP8.3 support
Also fixed text which could through deprecation notice due to not having a properly formed comment in use. For #4633
1 parent c640db8 commit fce7190

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

.github/workflows/test-migrations.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-22.04
1717
strategy:
1818
matrix:
19-
php: ['8.0', '8.1', '8.2']
19+
php: ['8.0', '8.1', '8.2', '8.3']
2020
steps:
2121
- uses: actions/checkout@v1
2222

.github/workflows/test-php.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-22.04
1717
strategy:
1818
matrix:
19-
php: ['8.0', '8.1', '8.2']
19+
php: ['8.0', '8.1', '8.2', '8.3']
2020
steps:
2121
- uses: actions/checkout@v1
2222

tests/Activity/WatchTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,10 @@ public function test_notifications_sent_in_right_language()
336336
$activities = [
337337
ActivityType::PAGE_CREATE => $entities['page'],
338338
ActivityType::PAGE_UPDATE => $entities['page'],
339-
ActivityType::COMMENT_CREATE => (new Comment([]))->forceFill(['entity_id' => $entities['page']->id, 'entity_type' => $entities['page']->getMorphClass()]),
339+
ActivityType::COMMENT_CREATE => Comment::factory()->make([
340+
'entity_id' => $entities['page']->id,
341+
'entity_type' => $entities['page']->getMorphClass(),
342+
]),
340343
];
341344

342345
$notifications = Notification::fake();

0 commit comments

Comments
 (0)