Added caching to the loading of system roles

ssddanbrown · ssddanbrown · commit 8abb41abbd58 · 2023-02-23T23:01:03.000Z
Admin system role was being loaded for each permission check performed.
This caches the fetching for the request lifetime.
diff --git a/app/Auth/Role.php b/app/Auth/Role.php
@@ -111,7 +111,13 @@ public static function getRole(string $displayName): ?self
      */
     public static function getSystemRole(string $systemName): ?self
     {
-        return static::query()->where('system_name', '=', $systemName)->first();
+        static $cache = [];
+
+        if (!isset($cache[$systemName])) {
+            $cache[$systemName] = static::query()->where('system_name', '=', $systemName)->first();
+        }
+
+        return $cache[$systemName];
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,13 @@ public static function getRole(string $displayName): ?self`
`111`	`111`	`*/`
`112`	`112`	`public static function getSystemRole(string $systemName): ?self`
`113`	`113`	`{`
`114`		`- return static::query()->where('system_name', '=', $systemName)->first();`
	`114`	`+ static $cache = [];`
	`115`	`+`
	`116`	`+ if (!isset($cache[$systemName])) {`
	`117`	`+ $cache[$systemName] = static::query()->where('system_name', '=', $systemName)->first();`
	`118`	`+ }`
	`119`	`+`
	`120`	`+ return $cache[$systemName];`
`115`	`121`	`}`
`116`	`122`
`117`	`123`	`/**`