WYSIWYG: Fixed filtering issue causing broken page edits

ssddanbrown · ssddanbrown · commit 2c20abc87245 · 2023-09-04T11:25:05.000+01:00
Could error upon div elements without classes, including drawings. Related to #4510 and #4509
diff --git a/resources/js/wysiwyg/filters.js b/resources/js/wysiwyg/filters.js
@@ -24,7 +24,9 @@ function setupBrFilter(editor) {
 function setupPointerFilter(editor) {
     editor.parser.addNodeFilter('div', nodes => {
         for (const node of nodes) {
-            if (node.attr('id') === 'pointer' || node.attr('class').includes('pointer')) {
+            const id = node.attr('id') || '';
+            const nodeClass = node.attr('class') || '';
+            if (id === 'pointer' || nodeClass.includes('pointer')) {
                 node.remove();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,9 @@ function setupBrFilter(editor) {`
`24`	`24`	`function setupPointerFilter(editor) {`
`25`	`25`	`editor.parser.addNodeFilter('div', nodes => {`
`26`	`26`	`for (const node of nodes) {`
`27`		`- if (node.attr('id') === 'pointer' \|\| node.attr('class').includes('pointer')) {`
	`27`	`+ const id = node.attr('id') \|\| '';`
	`28`	`+ const nodeClass = node.attr('class') \|\| '';`
	`29`	`+ if (id === 'pointer' \|\| nodeClass.includes('pointer')) {`
`28`	`30`	`node.remove();`
`29`	`31`	`}`
`30`	`32`	`}`