Skip to content

Conversation

@luiztools
Copy link

Modern Sequelize doesn't have findById anymore, so, we need to change this to add support to findByPk function.

Modern Sequelize doesn't have findById anymore, so, we need to change this to add support to findByPk function.
@tawfiknasser
Copy link

I agree that we need to support findByPk and it should replace it. but this is another functionality.
primary key is not always id. Pk column can be called in many names (id, UUID, ID).

also we need to refactor the tests if we are changing the function name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants