Skip to content

Commit 5341bcc

Browse files
l0rincPiRK
authored andcommitted
refactor coins_tests
Summary: From the PR description: > The last few commits contain significant test refactorings to make coins_tests easier to change in follow-ups. --- > test, refactor: Migrate GetCoinsMapEntry to return MaybeCoin bitcoin/bitcoin@ca74aa7 --- > test: Group values and states in tests into CoinEntry wrappers > > Note: that this commit affects the test order, but doesn't change its behavior or coverage otherwise. bitcoin/bitcoin@d5f8d60 --- > test: Validate error messages on fail > > The `ccoins_add` and `ccoins_write` tests check the actual exception error messages now instead of just that they fail for the given parameters. > This enables us testing different exceptions in a more fine-grained way in later changes. bitcoin/bitcoin@c0b4b2c --- > test, refactor: Remove remaining unbounded flags from coins_tests bitcoin/bitcoin@0a159f0 --- > test, refactor: Compact ccoins_access and ccoins_spend > > Also added an extra check for `AccessCoin` in `CheckAccessCoin` to make sure its result is also validated. bitcoin/bitcoin@50cce20 --- This concludes backport of [[bitcoin/bitcoin#30906 | core#30906]] Depends on D18809 Test Plan: `ninja check` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D18810
1 parent 4f73f04 commit 5341bcc

File tree

1 file changed

+293
-300
lines changed

1 file changed

+293
-300
lines changed

0 commit comments

Comments
 (0)