Cleanup

Author: patrick477

.travis.yml

@@ -42,7 +42,7 @@ before_script:
     - (cd tests/Application && bin/console doctrine:database:create --env=test -vvv)
     - (cd tests/Application && bin/console doctrine:schema:create --env=test -vvv)
     - (cd tests/Application && bin/console assets:install web --env=test -vvv)
-    - (cd tests/Application && bin/console fo:el:po --env=test)
+    - (cd tests/Application && bin/console fos:elastica:populate --env=test)
     - (cd tests/Application && yarn run gulp)
 
     # Configure display

features/shop/filtering_products.feature

@@ -8,7 +8,7 @@ Feature: Filtering products
         Given the store operates on a channel named "Web-US" in "USD" currency
         And the store classifies its products as "T-Shirts"
         And there are 45 t-shirts in the store
-        And this products belongs to "T-Shirts" taxon
+        And these products belongs to "T-Shirts" taxon
         And 5 of these products are priced between "$10" and "$15"
         And 10 of these products are priced between "$15" and "$35"
         And these products have "Size" option with values "S,M,L"
@@ -23,7 +23,7 @@ Feature: Filtering products
 
     @ui
     Scenario: Filtering products by name
-        When I go to the shop products page from taxon "T-Shirts"
+        When I go to the shop products page for "T-Shirts" taxon
         And I search the products by "shirt" phase
         Then I should see 9 products on 1 page
         And I should see 9 products on 2 page
@@ -33,35 +33,35 @@ Feature: Filtering products
 
     @ui
     Scenario: Filtering products by options
-        When I go to the shop products page from taxon "T-Shirts"
+        When I go to the shop products page for "T-Shirts" taxon
         And I filter products by "S" "Size" option
         And I filter products by "M" "Size" option
         Then I should see 8 products on the page
 
     @ui
     Scenario: Filtering products by attributes
-        When I go to the shop products page from taxon "T-Shirts"
+        When I go to the shop products page for "T-Shirts" taxon
         And I filter products by "Red" "color" attribute
         And I filter products by "Green" "color" attribute
         Then I should see 8 products on the page
 
     @ui
     Scenario: Filtering products by price
-        When I go to the shop products page from taxon "T-Shirts"
+        When I go to the shop products page for "T-Shirts" taxon
         And I filter product price between 10 and 15
         Then I should see 5 products on the page
 
     @ui
     Scenario: Changing limit from 9 to 18
-        When I go to the shop products page from taxon "T-Shirts"
+        When I go to the shop products page for "T-Shirts" taxon
         And I change the limit to 18
         Then I should see 18 products on 1 page
         And I should see 18 products on 2 page
         And I should see 9 products on 3 page
 
     @ui
     Scenario: Changing limit from 9 to 36
-        When I go to the shop products page from taxon "T-Shirts"
+        When I go to the shop products page for "T-Shirts" taxon
         And I change the limit to 36
         Then I should see 36 products on 1 page
         And I should see 9 products on 2 page

tests/Behat/Context/Setup/ElasticsearchContext.php

@@ -33,7 +33,7 @@ public function __construct(Populate $populate)
     /**
      * @Given the data is populated to elasticsearch
      */
-    public function populateElasticsearch(): void
+    public function theDataIsPopulatedToElasticsearch(): void
     {
         $this->populate->populateIndex();
     }

tests/Behat/Context/Setup/ProductTaxonContext.php

@@ -53,9 +53,9 @@ public function __construct(
     }
 
     /**
-     * @Given /^this products belongs to ("[^"]+" taxon)$/
+     * @Given /^these products belongs to ("[^"]+" taxon)$/
      */
-    public function thisProductsBelongsTo(TaxonInterface $taxon): void
+    public function theseProductsBelongsToTaxon(TaxonInterface $taxon): void
     {
         /** @var ProductInterface $product */
         foreach ($this->sharedStorage->get('products') as $product) {

tests/Behat/Context/Ui/Shop/ProductContext.php

@@ -40,9 +40,9 @@ public function __construct(IndexPageInterface $productIndexPage, SharedStorageI
     }
 
     /**
-     * @When /^I go to the shop products page from (taxon "([^"]+)")$/
+     * @When /^I go to the shop products page for ("([^"]+)" taxon)$/
      */
-    public function iGoToTheShopProductsPage(TaxonInterface $taxon): void
+    public function iGoToTheShopProductsPageForTaxon(TaxonInterface $taxon): void
     {
         $this->productIndexPage->open(['slug' => $taxon->getSlug()]);