Merge pull request #270 from BitBagCommerce/fix_sold_unit_populate

Fixing the condition in orderItemRepository.countByVariant

Author: christopherhero

.github/workflows/build.yml

@@ -159,7 +159,7 @@ jobs:
         run: vendor/bin/behat --colors --strict -vvv --no-interaction --tags '~@sylius112' || vendor/bin/behat --colors --strict -vvv --no-interaction --rerun --tags '~@sylius112'
 
       - name: Upload Behat logs
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: Behat logs

src/Repository/OrderItemRepository.php

@@ -25,7 +25,7 @@ public function __construct(
 
     public function countByVariant(ProductVariantInterface $variant, array $orderStates = []): int
     {
-        if ([] !== $orderStates) {
+        if ([] === $orderStates) {
             $orderStates = [OrderInterface::STATE_CANCELLED, OrderInterface::STATE_CART];
         }
 

tests/Application/.github/workflows/build.yml

@@ -187,9 +187,9 @@ jobs:
 
             -
                 name: Upload Behat logs
-                uses: actions/upload-artifact@v2
+                uses: actions/upload-artifact@v4
                 if: failure()
                 with:
                     name: Behat logs
                     path: etc/build/
-                    if-no-files-found: ignore
+                    if-no-files-found: ignore