refactor: Salesforce date time conversion

Author: RishadAlam

includes/Actions/GiveWp/RecordApiHelper.php

@@ -36,8 +36,11 @@ public function createGiveWpDonar($finalData)
             '_give_donor_last_name'  => 'last_name',
         ];
 
-        $donor = new Give_Donor();
+        if (!class_exists('Give_Donor') || !\function_exists('Give')) {
+            return;
+        }
 
+        $donor = new Give_Donor();
         $donorId = $donor->create($finalData);
 
         if (is_numeric($donorId)) {

includes/Actions/Salesforce/RecordApiHelper.php

@@ -292,14 +292,22 @@ public static function convertToSalesforceFormat($input)
 
             $input = trim($input);
 
-            // ------------------------------------------------------------
-            // 1) Handle UNIX timestamps (10 or 13 digits)
-            // ------------------------------------------------------------
-            if (preg_match('/^\d{10}$/', $input)) {
-                return gmdate('Y-m-d\TH:i:s\Z', (int) $input);
+            if (empty($input)) {
+                return $input;
             }
-            if (preg_match('/^\d{13}$/', $input)) {
-                return gmdate('Y-m-d\TH:i:s\Z', (int) ($input / 1000));
+
+            if (is_numeric($input)) {
+                return $input;
+
+                // ------------------------------------------------------------
+                // 1) Handle UNIX timestamps (10 or 13 digits)
+                // ------------------------------------------------------------
+                if (\strlen($input) === 10 && preg_match('/^\d{10}$/', $input)) {
+                    return gmdate('Y-m-d\TH:i:s\Z', (int) $input);
+                }
+                if (\strlen($input) === 13 && preg_match('/^\d{13}$/', $input)) {
+                    return gmdate('Y-m-d\TH:i:s\Z', (int) ($input / 1000));
+                }
             }
 
             // ------------------------------------------------------------
@@ -356,7 +364,7 @@ public static function convertToSalesforceFormat($input)
             // ------------------------------------------------------------
             // 7) Compact numeric formats (01022025, 20250201, 250201, 010225)
             // ------------------------------------------------------------
-            if (preg_match('/^\d{8}$/', $clean)) {
+            if (\strlen($clean) === 8 && preg_match('/^\d{8}$/', $clean)) {
                 // YYYYMMDD or DDMMYYYY or MMDDYYYY → try multiple interpretations
                 $candidates = [
                     substr($clean, 0, 4) . '-' . substr($clean, 4, 2) . '-' . substr($clean, 6, 2), // YMD
@@ -369,7 +377,7 @@ public static function convertToSalesforceFormat($input)
                 }
             }
 
-            if (preg_match('/^\d{6}$/', $clean)) {
+            if (\strlen($clean) === 6 && preg_match('/^\d{6}$/', $clean)) {
                 // DDMMYY / YYMMDD / MMDDYY
                 $yy = \intval(substr($clean, -2));
 
@@ -399,15 +407,7 @@ public static function convertToSalesforceFormat($input)
             // ------------------------------------------------------------
             // 8) Try direct DateTime parsing for most formats
             // ------------------------------------------------------------
-            $tryParse = function ($value) {
-                try {
-                    return new DateTimeImmutable($value);
-                } catch (Throwable $e) {
-                    return;
-                }
-            };
-
-            $dt = $tryParse($clean);
+            $dt = self::tryParseDateTimeImmutable($clean);
 
             if ($dt instanceof DateTimeImmutable) {
                 // Detect if datetime or pure date
@@ -440,4 +440,13 @@ public static function convertToSalesforceFormat($input)
             return $input;
         }
     }
+
+    private static function tryParseDateTimeImmutable($value)
+    {
+        try {
+            return new DateTimeImmutable($value);
+        } catch (Throwable $e) {
+            return;
+        }
+    }
 }