refactor: db query placeholders

Author: RishadAlam

bin/bump-version.php

@@ -55,4 +55,4 @@ function ($matches) use ($newVersion) {
 file_put_contents($configFile, $configContent);
 file_put_contents($readmeFile, $readmeContent);
 
-echo "Updated Version v{$newVersion}" . "\n";
+echo "Updated Version v{$newVersion}\n";

includes/Actions/GamiPress/GamiPressController.php

@@ -89,7 +89,7 @@ public static function fetchAllAchievementType()
         global $wpdb;
 
         return $wpdb->get_results(
-            $wpdb->prepare("SELECT ID, post_name, post_title, post_type FROM {$wpdb->posts} WHERE post_type LIKE %s AND post_status = 'publish' ORDER BY post_title ASC", 'achievement-type')
+            $wpdb->prepare("SELECT ID, post_name, post_title, post_type FROM %1s WHERE post_type LIKE %2s AND post_status = 'publish' ORDER BY post_title ASC", $wpdb->posts, 'achievement-type')
         );
     }
 
@@ -109,7 +109,7 @@ public static function fetchAllPointType()
     {
         global $wpdb;
         $points = $wpdb->get_results(
-            $wpdb->prepare("SELECT ID, post_name, post_title, post_type FROM {$wpdb->posts} WHERE post_type LIKE %s AND post_status = 'publish' ORDER BY post_title ASC", 'points-type')
+            $wpdb->prepare("SELECT ID, post_name, post_title, post_type FROM %1s WHERE post_type LIKE %2s AND post_status = 'publish' ORDER BY post_title ASC", $wpdb->posts, 'points-type')
         );
         wp_send_json_success($points);
     }

includes/Actions/WooCommerce/WooCommerceController.php

@@ -273,18 +273,24 @@ public function searchProjects($queryParams)
     public static function allSubscriptionsProducts()
     {
         global $wpdb;
-        $allSubscriptions = $wpdb->get_results("
-        	SELECT posts.ID, posts.post_title FROM {$wpdb->posts} as posts
-        	LEFT JOIN {$wpdb->term_relationships} as rel ON (posts.ID = rel.object_id)
-        	WHERE rel.term_taxonomy_id IN (SELECT term_id FROM {$wpdb->terms} WHERE slug IN ('subscription','variable-subscription'))
-        	AND posts.post_type = 'product'
-        	AND posts.post_status = 'publish'
-        	UNION ALL
-        	SELECT ID, post_title FROM {$wpdb->posts}
-        	WHERE post_type = 'shop_subscription'
-        	AND post_status = 'publish'
-        	ORDER BY post_title
-        ");
+        $allSubscriptions = $wpdb->get_results(
+            $wpdb->prepare(
+                "SELECT posts.ID, posts.post_title FROM %1s as posts
+        	    LEFT JOIN %2s as rel ON (posts.ID = rel.object_id)
+        	    WHERE rel.term_taxonomy_id IN (SELECT term_id FROM %3s WHERE slug IN ('subscription','variable-subscription'))
+        	    AND posts.post_type = 'product'
+        	    AND posts.post_status = 'publish'
+        	    UNION ALL
+        	    SELECT ID, post_title FROM %4s
+        	    WHERE post_type = 'shop_subscription'
+        	    AND post_status = 'publish'
+        	    ORDER BY post_title",
+                $wpdb->posts,
+                $wpdb->term_relationships,
+                $wpdb->terms,
+                $wpdb->posts
+            )
+        );
 
         $subscriptions[] = [
             'product_id'   => 'any',

includes/Core/Util/UnInstallation.php

@@ -50,9 +50,21 @@ public function uninstall()
         }
 
         foreach ($columns as $column) {
-            $wpdb->query($wpdb->prepare("DELETE FROM `{$wpdb->prefix}options` WHERE option_name= %s", $column));
+            $wpdb->query(
+                $wpdb->prepare(
+                    'DELETE FROM %1s WHERE option_name= %2s',
+                    "{$wpdb->prefix}options",
+                    $column,
+                )
+            );
         }
 
-        $wpdb->query($wpdb->prepare("DELETE FROM `{$wpdb->prefix}options` WHERE `option_name` LIKE %s", '%btcbi_webhook_%'));
+        $wpdb->query(
+            $wpdb->prepare(
+                'DELETE FROM %1s WHERE `option_name` LIKE %2s',
+                "{$wpdb->prefix}options",
+                '%btcbi_webhook_%'
+            )
+        );
     }
 }