refactor: salesforce contact update helpers

RishadAlam · RishadAlam · commit 29c3942eb878 · 2025-11-09T17:05:47.000+06:00
diff --git a/includes/Actions/Salesforce/RecordApiHelper.php b/includes/Actions/Salesforce/RecordApiHelper.php
@@ -47,16 +47,10 @@ public function insertContact($finalData, $update = false)
 
         $response = HttpHelper::post($apiEndpoint, wp_json_encode($finalData), $this->_defaultHeader);
 
-        $duplicateRecordId = isset($response[0]->duplicateResult->matchResults[0]->matchRecords[0]->record->Id)
-        ? $response[0]->duplicateResult->matchResults[0]->matchRecords[0]->record->Id
-        : null;
-
-        if (!$update || !$duplicateRecordId) {
+        if (!$update) {
             return $response;
         }
 
-        $apiEndpoint = $apiEndpoint . '/' . $duplicateRecordId;
-
         return apply_filters('btcbi_salesforce_update_record', $response, $apiEndpoint, $finalData, $this->_defaultHeader);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -47,16 +47,10 @@ public function insertContact($finalData, $update = false)`
`47`	`47`
`48`	`48`	`$response = HttpHelper::post($apiEndpoint, wp_json_encode($finalData), $this->_defaultHeader);`
`49`	`49`
`50`		`- $duplicateRecordId = isset($response[0]->duplicateResult->matchResults[0]->matchRecords[0]->record->Id)`
`51`		`- ? $response[0]->duplicateResult->matchResults[0]->matchRecords[0]->record->Id`
`52`		`- : null;`
`53`		`-`
`54`		`- if (!$update \|\| !$duplicateRecordId) {`
	`50`	`+ if (!$update) {`
`55`	`51`	`return $response;`
`56`	`52`	`}`
`57`	`53`
`58`		`- $apiEndpoint = $apiEndpoint . '/' . $duplicateRecordId;`
`59`		`-`
`60`	`54`	`return apply_filters('btcbi_salesforce_update_record', $response, $apiEndpoint, $finalData, $this->_defaultHeader);`
`61`	`55`	`}`
`62`	`56`