Merge pull request #24 from BeverCRM/feature/error

fixed bugs related to "error message" and "column width"

Author: Hovhannes-Dilanyan

FetchToSubgrid/services/dataverseService.ts

@@ -102,9 +102,7 @@ export class DataverseService implements IDataverseService {
       const formParameters: { [key: string]: string } =
        { [relationship.ReferencingAttribute]: JSON.stringify(lookup) };
 
-      this._context.navigation.openForm({ entityName }, formParameters)
-        .then((success: unknown) => console.log(success))
-        .catch((error: unknown) => console.log(error));
+      this._context.navigation.openForm({ entityName }, formParameters);
     }
     else {
       this._context.navigation.openForm({ entityName });
@@ -176,7 +174,7 @@ export class DataverseService implements IDataverseService {
       fetch?.removeAttribute('count');
       fetch?.removeAttribute('page');
 
-      fetch.setAttribute('page', `${page}`);
+      fetch?.setAttribute('page', `${page}`);
 
       const serializer = new XMLSerializer();
       return serializer.serializeToString(xmlDoc);

FetchToSubgrid/utilities/d365Utils.ts

@@ -78,8 +78,8 @@ const createColumnsForLinkEntity = (
         changedAliasNames, attr, index, i, linkEntityName);
 
       const columnName: string = attr.attributeAlias ||
-        linkentityMetadata[i].Attributes._collection[attr.name].DisplayName;
-      const attributeType = linkentityMetadata[i].Attributes._collection[attr.name].AttributeType;
+        linkentityMetadata[i].Attributes._collection[attr.name]?.DisplayName;
+      const attributeType = linkentityMetadata[i].Attributes._collection[attr.name]?.AttributeType;
 
       const isMultiselectPickList = attributeType === AttributeType.MultiselectPickList;
       const sortingIsAllowed = isMultiselectPickList || hasAggregate || changedAliasNames[index];
@@ -120,9 +120,9 @@ const createColumnsForEntity = (
 
     let displayName = name === `${entityName}id`
       ? 'Primary Key'
-      : displayNameCollection[name].DisplayName;
+      : displayNameCollection[name]?.DisplayName;
 
-    const attributeType: number = displayNameCollection[name].AttributeType;
+    const attributeType: number = displayNameCollection[name]?.AttributeType;
     const hasAggregate: boolean = isAggregate(fetchXml ?? '');
     const aliasNames: string[] | null = getFetchXmlAttributesData(fetchXml, false);
     const isMultiselectPickList = attributeType === AttributeType.MultiselectPickList;

FetchToSubgrid/utilities/fetchXmlUtils.ts

@@ -10,7 +10,7 @@ export const changeAliasNames = (fetchXml: string) => {
 
   attributeElements.forEach((attributeElement, index) => {
     const newAliasValue = `alias${index}`;
-    attributeElement.setAttribute('alias', newAliasValue);
+    attributeElement?.setAttribute('alias', newAliasValue);
   });
 
   return xmlDoc.documentElement.outerHTML;
@@ -35,8 +35,8 @@ export const addPagingToFetchXml = (
     recordsPerPage = Number(top) % pageSize;
   }
 
-  fetch.setAttribute('page', `${currentPage}`);
-  fetch.setAttribute('count', `${recordsPerPage}`);
+  fetch?.setAttribute('page', `${currentPage}`);
+  fetch?.setAttribute('count', `${recordsPerPage}`);
 
   const newFetchChangedAliases = changeAliasNames(new XMLSerializer().serializeToString(xmlDoc));
 
@@ -90,8 +90,8 @@ export const addOrderToFetch = (
   }
 
   const newOrder: HTMLElement = xmlDoc.createElement('order');
-  newOrder.setAttribute('attribute', `${sortingData.fieldName}`);
-  newOrder.setAttribute('descending', `${!sortingData.column?.isSortedDescending}`);
+  newOrder?.setAttribute('attribute', `${sortingData.fieldName}`);
+  newOrder?.setAttribute('descending', `${!sortingData.column?.isSortedDescending}`);
 
   if (sortingData.column?.className === 'linkEntity') {
     linkEntity?.appendChild(newOrder);

FetchToSubgrid/utilities/utils.ts

@@ -172,7 +172,7 @@ export const hashCode = (str: string) => {
   for (let i = 0; i < str.length; i++) {
     const charCode = str.charCodeAt(i);
     hash = ((hash << 5) - hash) + charCode;
-    hash |= 0; // Convert to 32bit integer
+    hash |= 0;
   }
   return hash;
 };
@@ -229,7 +229,7 @@ export const generateItemsForEntity = (
   recordsData.attributesFieldNames.forEach((fieldName: any, index: number) => {
     const hasAliasValue = !!recordsData.entityAliases[index];
     const attributeType: number = recordsData.entityMetadata.Attributes.get(
-      fieldName).AttributeType;
+      fieldName)?.AttributeType;
 
     if (recordsData.entityAliases[index]) {
       fieldName = recordsData.entityAliases[index];
@@ -258,7 +258,7 @@ export const generateItemsForLinkEntity = (
     recordsData.linkEntityAttributes[i].forEach((attr: any, index: number) => {
       const hasAliasValue = !!attr.linkEntityAlias;
       const attributeType: number = recordsData.linkentityMetadata[i].Attributes.get(
-        attr.name).AttributeType;
+        attr.name)?.AttributeType;
       const fieldName = getAttributeAliasName(attr, i, linkEntityName);
 
       const attributes: IItemProps = {