Skip to content
This repository was archived by the owner on Mar 5, 2024. It is now read-only.

Commit b14ed65

Browse files
committed
Change event names to be 'on*'. This fixes issues with the window:resize hook. Closes #74
1 parent 6748e82 commit b14ed65

File tree

4 files changed

+125
-127
lines changed

4 files changed

+125
-127
lines changed

README.md

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -82,31 +82,31 @@ The defaults for the grid item are:
8282
Both the `NgGrid` and `NgGridItem` throw events when an item is moved or resized. The grid has the following:
8383

8484
```javascript
85-
dragStart(item) // When an item starts being dragged. Returns reference to corresponding NgGridItem
86-
drag(item) // When an item moves while dragging. Returns reference to corresponding NgGridItem
87-
dragStop(item) // When an item stops being dragged. Returns reference to corresponding NgGridItem
88-
resizeStart(item) // When an item starts being resized. Returns reference to corresponding NgGridItem
89-
resize(item) // When an item is resized. Returns reference to corresponding NgGridItem
90-
resizeStop(item) // When an item stops being resized. Returns reference to corresponding NgGridItem
91-
itemChange(items) // When any item stops being dragged or resized. Returns an array of NgGridItemEvents in the order in which each item was added to the grid
85+
onDragStart(item) // When an item starts being dragged. Returns reference to corresponding NgGridItem
86+
onDrag(item) // When an item moves while dragging. Returns reference to corresponding NgGridItem
87+
onDragStop(item) // When an item stops being dragged. Returns reference to corresponding NgGridItem
88+
onResizeStart(item) // When an item starts being resized. Returns reference to corresponding NgGridItem
89+
onResize(item) // When an item is resized. Returns reference to corresponding NgGridItem
90+
onResizeStop(item) // When an item stops being resized. Returns reference to corresponding NgGridItem
91+
onItemChange(items) // When any item stops being dragged or resized. Returns an array of NgGridItemEvents in the order in which each item was added to the grid
9292
```
9393

9494
The individual items will also throw the following events:
9595

9696
```javascript
97-
dragStart() // When the item starts being dragged.
98-
drag() // When the item moves while dragging.
99-
dragStop() // When the item stops being dragged.
100-
dragAny() // When the item starts/stops/is being dragged.
101-
resizeStart() // When the item starts being resized.
102-
resize() // When the item is resized.
103-
resizeStop() // When the item stops being resized.
104-
resizeAny() // When the item starts/stops/is being resized.
105-
changeStart() // When the item starts being dragged or resized.
106-
change() // When the item is dragged or resized.
107-
changeStop() // When the item stops being dragged or resized.
108-
changeAny() // When the item starts/stops/is being dragged or resized.
109-
itemChange() // When either the item's grid size or position is changed.
97+
onDragStart() // When the item starts being dragged.
98+
onDrag() // When the item moves while dragging.
99+
onDragStop() // When the item stops being dragged.
100+
onDragAny() // When the item starts/stops/is being dragged.
101+
onResizeStart() // When the item starts being resized.
102+
onResize() // When the item is resized.
103+
onResizeStop() // When the item stops being resized.
104+
onResizeAny() // When the item starts/stops/is being resized.
105+
onChangeStart() // When the item starts being dragged or resized.
106+
onChange() // When the item is dragged or resized.
107+
onChangeStop() // When the item stops being dragged or resized.
108+
onChangeAny() // When the item starts/stops/is being dragged or resized.
109+
onItemChange() // When either the item's grid size or position is changed.
110110
```
111111

112112
Each event will also provide the following object to any callback functions:

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"dist/NgGrid.*"
3737
],
3838
"peerDependencies": {
39-
"angular2": "^2.0.0-beta.15"
39+
"angular2": "^2.0.0-beta.16"
4040
},
4141
"devDependencies": {
4242
"angular2": "^2.0.0-beta.16",
@@ -59,7 +59,7 @@
5959
"phantomjs": "^1.9.19",
6060
"reflect-metadata": "0.1.2",
6161
"run-sequence": "^1.1.5",
62-
"rxjs": "5.0.0-beta.2",
62+
"rxjs": "^5.0.0-beta.6",
6363
"systemjs": "^0.19.4",
6464
"typescript": "^1.6.2",
6565
"zone.js": "^0.6.6"

src/NgGrid.d.ts

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ export declare class NgGrid implements OnInit, DoCheck, OnDestroy {
2626
private _renderer;
2727
private _loader;
2828
private _containerRef;
29-
dragStart: EventEmitter<NgGridItem>;
30-
drag: EventEmitter<NgGridItem>;
31-
dragStop: EventEmitter<NgGridItem>;
32-
resizeStart: EventEmitter<NgGridItem>;
33-
resize: EventEmitter<NgGridItem>;
34-
resizeStop: EventEmitter<NgGridItem>;
35-
itemChange: EventEmitter<Array<NgGridItemEvent>>;
29+
onDragStart: EventEmitter<NgGridItem>;
30+
onDrag: EventEmitter<NgGridItem>;
31+
onDragStop: EventEmitter<NgGridItem>;
32+
onResizeStart: EventEmitter<NgGridItem>;
33+
onResize: EventEmitter<NgGridItem>;
34+
onResizeStop: EventEmitter<NgGridItem>;
35+
onItemChange: EventEmitter<Array<NgGridItemEvent>>;
3636
colWidth: number;
3737
rowHeight: number;
3838
minCols: number;
@@ -160,19 +160,19 @@ export declare class NgGridItem implements OnInit, OnDestroy {
160160
private _renderer;
161161
private _ngGrid;
162162
containerRef: ViewContainerRef;
163-
itemChange: EventEmitter<NgGridItemEvent>;
164-
dragStart: EventEmitter<NgGridItemEvent>;
165-
drag: EventEmitter<NgGridItemEvent>;
166-
dragStop: EventEmitter<NgGridItemEvent>;
167-
dragAny: EventEmitter<NgGridItemEvent>;
168-
resizeStart: EventEmitter<NgGridItemEvent>;
169-
resize: EventEmitter<NgGridItemEvent>;
170-
resizeStop: EventEmitter<NgGridItemEvent>;
171-
resizeAny: EventEmitter<NgGridItemEvent>;
172-
changeStart: EventEmitter<NgGridItemEvent>;
173-
change: EventEmitter<NgGridItemEvent>;
174-
changeStop: EventEmitter<NgGridItemEvent>;
175-
changeAny: EventEmitter<NgGridItemEvent>;
163+
onItemChange: EventEmitter<NgGridItemEvent>;
164+
onDragStart: EventEmitter<NgGridItemEvent>;
165+
onDrag: EventEmitter<NgGridItemEvent>;
166+
onDragStop: EventEmitter<NgGridItemEvent>;
167+
onDragAny: EventEmitter<NgGridItemEvent>;
168+
onResizeStart: EventEmitter<NgGridItemEvent>;
169+
onResize: EventEmitter<NgGridItemEvent>;
170+
onResizeStop: EventEmitter<NgGridItemEvent>;
171+
onResizeAny: EventEmitter<NgGridItemEvent>;
172+
onChangeStart: EventEmitter<NgGridItemEvent>;
173+
onChange: EventEmitter<NgGridItemEvent>;
174+
onChangeStop: EventEmitter<NgGridItemEvent>;
175+
onChangeAny: EventEmitter<NgGridItemEvent>;
176176
private static CONST_DEFAULT_CONFIG;
177177
gridPosition: {
178178
'col': number;
@@ -200,12 +200,12 @@ export declare class NgGridItem implements OnInit, OnDestroy {
200200
private _added;
201201
config: NgGridItemConfig;
202202
constructor(_ngEl: ElementRef, _renderer: Renderer, _ngGrid: NgGrid, containerRef: ViewContainerRef);
203-
onResizeStart(): void;
204-
onResize(): void;
205-
onResizeStop(): void;
206-
onDragStart(): void;
207-
onDrag(): void;
208-
onDragStop(): void;
203+
onResizeStartEvent(): void;
204+
onResizeEvent(): void;
205+
onResizeStopEvent(): void;
206+
onDragStartEvent(): void;
207+
onDragEvent(): void;
208+
onDragStopEvent(): void;
209209
ngOnInit(): void;
210210
canDrag(e: any): boolean;
211211
canResize(e: any): string;
@@ -231,8 +231,8 @@ export declare class NgGridItem implements OnInit, OnDestroy {
231231
row: number;
232232
};
233233
setConfig(config: NgGridItemConfig): void;
234-
setSize(x: number, y: number): void;
235-
setGridPosition(col: number, row: number): void;
234+
setSize(x: number, y: number, update?: boolean): void;
235+
setGridPosition(col: number, row: number, update?: boolean): void;
236236
getEventOutput(): NgGridItemEvent;
237237
setPosition(x: number, y: number): void;
238238
setDimensions(w: number, h: number): void;

0 commit comments

Comments
 (0)