[Key Vault] Rename id parameter -> source_id (Azure#18995)

Author: mccoyp

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_models.py

@@ -395,7 +395,7 @@ def cer(self):
 class KeyVaultCertificateIdentifier(object):
     """Information about a KeyVaultCertificate parsed from a certificate ID.
 
-    :param str id: the full original identifier of a certificate
+    :param str source_id: the full original identifier of a certificate
     :raises ValueError: if the certificate ID is improperly formatted
     Example:
         .. literalinclude:: ../tests/test_parse_id.py
@@ -406,9 +406,9 @@ class KeyVaultCertificateIdentifier(object):
             :dedent: 8
     """
 
-    def __init__(self, id):  # pylint: disable=W0622
+    def __init__(self, source_id):
         # type: (str) -> None
-        self._resource_id = parse_key_vault_id(id)
+        self._resource_id = parse_key_vault_id(source_id)
 
     @property
     def source_id(self):

sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py

@@ -349,7 +349,7 @@ def test_recover_and_purge(self, client, **kwargs):
             client.begin_delete_certificate(certificate_name=cert_name).wait()
 
         # validate all our deleted certificates are returned by list_deleted_certificates
-        deleted = [KeyVaultCertificateIdentifier(id=c.id).name for c in client.list_deleted_certificates()]
+        deleted = [KeyVaultCertificateIdentifier(source_id=c.id).name for c in client.list_deleted_certificates()]
         self.assertTrue(all(c in deleted for c in certs.keys()))
 
         # recover select certificates (test resources have a "livekvtest" prefix)
@@ -364,7 +364,7 @@ def test_recover_and_purge(self, client, **kwargs):
             time.sleep(50)
 
         # validate none of our deleted certificates are returned by list_deleted_certificates
-        deleted = [KeyVaultCertificateIdentifier(id=c.id).name for c in client.list_deleted_certificates()]
+        deleted = [KeyVaultCertificateIdentifier(source_id=c.id).name for c in client.list_deleted_certificates()]
         self.assertTrue(not any(c in deleted for c in certs.keys()))
 
         # validate the recovered certificates

sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client_async.py

@@ -350,7 +350,7 @@ async def test_recover_and_purge(self, client, **kwargs):
         deleted_certificates = client.list_deleted_certificates()
         deleted = []
         async for c in deleted_certificates:
-            deleted.append(KeyVaultCertificateIdentifier(id=c.id).name)
+            deleted.append(KeyVaultCertificateIdentifier(source_id=c.id).name)
         self.assertTrue(all(c in deleted for c in certs.keys()))
 
         # recover select certificates (test resources have a "livekvtest" prefix)
@@ -368,7 +368,7 @@ async def test_recover_and_purge(self, client, **kwargs):
         deleted_certificates = client.list_deleted_certificates()
         deleted = []
         async for c in deleted_certificates:
-            deleted.append(KeyVaultCertificateIdentifier(id=c.id).name)
+            deleted.append(KeyVaultCertificateIdentifier(source_id=c.id).name)
         self.assertTrue(not any(c in deleted for c in certs.keys()))
 
         # validate the recovered certificates

sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_models.py

@@ -328,7 +328,7 @@ def key_operations(self):
 class KeyVaultKeyIdentifier(object):
     """Information about a KeyVaultKey parsed from a key ID.
 
-    :param str id: the full original identifier of a key
+    :param str source_id: the full original identifier of a key
     :raises ValueError: if the key ID is improperly formatted
     Example:
         .. literalinclude:: ../tests/test_parse_id.py
@@ -339,9 +339,9 @@ class KeyVaultKeyIdentifier(object):
             :dedent: 8
     """
 
-    def __init__(self, id):  # pylint: disable=W0622
+    def __init__(self, source_id):
         # type: (str) -> None
-        self._resource_id = parse_key_vault_id(id)
+        self._resource_id = parse_key_vault_id(source_id)
 
     @property
     def source_id(self):

sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_models.py

@@ -248,7 +248,7 @@ def value(self):
 class KeyVaultSecretIdentifier(object):
     """Information about a KeyVaultSecret parsed from a secret ID.
 
-    :param str id: the full original identifier of a secret
+    :param str source_id: the full original identifier of a secret
     :raises ValueError: if the secret ID is improperly formatted
     Example:
         .. literalinclude:: ../tests/test_parse_id.py
@@ -259,9 +259,9 @@ class KeyVaultSecretIdentifier(object):
             :dedent: 8
     """
 
-    def __init__(self, id):  # pylint: disable=W0622
+    def __init__(self, source_id):
         # type: (str) -> None
-        self._resource_id = parse_key_vault_id(id)
+        self._resource_id = parse_key_vault_id(source_id)
 
     @property
     def source_id(self):