Skip to content

Commit aebd212

Browse files
authored
Correct Visual Studio Code default environment name (Azure#14648)
1 parent 12725f5 commit aebd212

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

sdk/identity/azure-identity/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,14 @@
1616
- Raised minimum msal version to 1.6.0
1717

1818
### Fixed
19+
- Prevent `VisualStudioCodeCredential` using invalid authentication data when
20+
no user is signed in to Visual Studio Code
21+
([#14438](https://github.com/Azure/azure-sdk-for-python/issues/14438))
1922
- `ManagedIdentityCredential` uses the API version supported by Azure Functions
2023
on Linux consumption hosting plans
2124
([#14670](https://github.com/Azure/azure-sdk-for-python/issues/14670))
2225

26+
2327
## 1.5.0b2 (2020-10-07)
2428
### Fixed
2529
- `AzureCliCredential.get_token` correctly sets token expiration time,

sdk/identity/azure-identity/azure/identity/_internal/linux_vscode_adapter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ def _get_user_settings():
5959
try:
6060
with open(path) as file:
6161
data = json.load(file)
62-
environment_name = data.get("azure.cloud", "Azure")
62+
environment_name = data.get("azure.cloud", "AzureCloud")
6363
return environment_name
6464
except IOError:
65-
return "Azure"
65+
return "AzureCloud"
6666

6767

6868
def _get_refresh_token(service_name, account_name):

sdk/identity/azure-identity/azure/identity/_internal/macos_vscode_adapter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ def _get_user_settings():
2121
try:
2222
with open(path) as file:
2323
data = json.load(file)
24-
environment_name = data.get("azure.cloud", "Azure")
24+
environment_name = data.get("azure.cloud", "AzureCloud")
2525
return environment_name
2626
except IOError:
27-
return "Azure"
27+
return "AzureCloud"
2828

2929

3030
def _get_refresh_token(service_name, account_name):

sdk/identity/azure-identity/azure/identity/_internal/win_vscode_adapter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ def _get_user_settings():
6767
try:
6868
with open(path) as file:
6969
data = json.load(file)
70-
environment_name = data.get("azure.cloud", "Azure")
70+
environment_name = data.get("azure.cloud", "AzureCloud")
7171
return environment_name
7272
except IOError:
73-
return "Azure"
73+
return "AzureCloud"
7474

7575

7676
def _get_refresh_token(service_name, account_name):

0 commit comments

Comments
 (0)