Skip to content

Commit 8ba6f29

Browse files
authored
Don't pass loop if not defined (Azure#23202)
* Don't pass loop if not defined * Be more precise on the test
1 parent f713678 commit 8ba6f29

File tree

1 file changed

+8
-6
lines changed
  • sdk/core/azure-core/azure/core/pipeline/transport

1 file changed

+8
-6
lines changed

sdk/core/azure-core/azure/core/pipeline/transport/_aiohttp.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,14 @@ async def open(self):
9797
"""
9898
if not self.session and self._session_owner:
9999
jar = aiohttp.DummyCookieJar()
100-
self.session = aiohttp.ClientSession(
101-
loop=self._loop,
102-
trust_env=self._use_env_settings,
103-
cookie_jar=jar,
104-
auto_decompress=False,
105-
)
100+
clientsession_kwargs = {
101+
"trust_env": self._use_env_settings,
102+
"cookie_jar": jar,
103+
"auto_decompress": False,
104+
}
105+
if self._loop is not None:
106+
clientsession_kwargs["loop"] = self._loop
107+
self.session = aiohttp.ClientSession(**clientsession_kwargs)
106108
if self.session is not None:
107109
await self.session.__aenter__()
108110

0 commit comments

Comments
 (0)