Skip to content

Commit 8926a2f

Browse files
author
Rakshith Bhyravabhotla
authored
Add Logs Batch query results (Azure#20013)
* Add Logs Batch query results * logs query results to result
1 parent ac60fb9 commit 8926a2f

14 files changed

+37
-33
lines changed

sdk/monitor/azure-monitor-query/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@
66
### Features Added
77

88
- Added enum `AggregationType` which can be used to specify aggregations in the query API.
9+
- Added `LogsBatchQueryResult` model that is returned for a logs batch query.
910

1011
### Breaking Changes
1112

1213
- `aggregation` param in the query API is renamed to `aggregations`
1314
- `batch_query` API now returns a list of responses.
1415
- `LogsBatchResults` model is now removed.
1516
- `LogsQueryRequest` is renamed to `LogsBatchQueryRequest`
17+
- `LogsQueryResults` is now renamed to `LogsQueryResult`
1618

1719
### Bugs Fixed
1820

sdk/monitor/azure-monitor-query/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ client = LogsQueryClient(credential)
131131
query = """AppRequests |
132132
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId"""
133133

134-
# returns LogsQueryResults
134+
# returns LogsQueryResult
135135
response = client.query(
136136
os.environ['LOG_WORKSPACE_ID'],
137137
query,

sdk/monitor/azure-monitor-query/azure/monitor/query/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99

1010
from ._models import (
1111
AggregationType,
12-
LogsQueryResults,
12+
LogsBatchQueryResult,
13+
LogsQueryResult,
1314
LogsQueryResultTable,
1415
LogsQueryResultColumn,
1516
MetricsResult,
@@ -29,8 +30,9 @@
2930
__all__ = [
3031
"AggregationType",
3132
"LogsQueryClient",
33+
"LogsBatchQueryResult",
3234
"LogsBatchResultError",
33-
"LogsQueryResults",
35+
"LogsQueryResult",
3436
"LogsQueryResultColumn",
3537
"LogsQueryResultTable",
3638
"LogsBatchQueryRequest",

sdk/monitor/azure-monitor-query/azure/monitor/query/_log_query_client.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
from ._generated.models import BatchRequest, QueryBody as LogsQueryBody
1414
from ._helpers import get_authentication_policy, process_error, construct_iso8601, order_results
15-
from ._models import LogsQueryResults, LogsBatchQueryRequest, LogsQueryResult
15+
from ._models import LogsQueryResult, LogsBatchQueryRequest, LogsBatchQueryResult
1616

1717
if TYPE_CHECKING:
1818
from azure.core.credentials import TokenCredential
@@ -50,7 +50,7 @@ def __init__(self, credential, **kwargs):
5050
self._query_op = self._client.query
5151

5252
def query(self, workspace_id, query, duration=None, **kwargs):
53-
# type: (str, str, Optional[timedelta], Any) -> LogsQueryResults
53+
# type: (str, str, Optional[timedelta], Any) -> LogsQueryResult
5454
"""Execute an Analytics query.
5555
5656
Executes an Analytics query for data.
@@ -81,7 +81,7 @@ def query(self, workspace_id, query, duration=None, **kwargs):
8181
These can be qualified workspace names, workspace Ids, or Azure resource Ids.
8282
:paramtype additional_workspaces: list[str]
8383
:return: QueryResults, or the result of cls(response)
84-
:rtype: ~azure.monitor.query.LogsQueryResults
84+
:rtype: ~azure.monitor.query.LogsQueryResult
8585
:raises: ~azure.core.exceptions.HttpResponseError
8686
8787
.. admonition:: Example:
@@ -121,7 +121,7 @@ def query(self, workspace_id, query, duration=None, **kwargs):
121121
)
122122

123123
try:
124-
return LogsQueryResults._from_generated(self._query_op.execute( # pylint: disable=protected-access
124+
return LogsQueryResult._from_generated(self._query_op.execute( # pylint: disable=protected-access
125125
workspace_id=workspace_id,
126126
body=body,
127127
prefer=prefer,
@@ -131,7 +131,7 @@ def query(self, workspace_id, query, duration=None, **kwargs):
131131
process_error(e)
132132

133133
def batch_query(self, queries, **kwargs):
134-
# type: (Union[Sequence[Dict], Sequence[LogsBatchQueryRequest]], Any) -> Sequence[LogsQueryResult]
134+
# type: (Union[Sequence[Dict], Sequence[LogsBatchQueryRequest]], Any) -> Sequence[LogsBatchQueryResult]
135135
"""Execute a list of analytics queries. Each request can be either a LogQueryRequest
136136
object or an equivalent serialized model.
137137
@@ -140,7 +140,7 @@ def batch_query(self, queries, **kwargs):
140140
:param queries: The list of queries that should be processed
141141
:type queries: list[dict] or list[~azure.monitor.query.LogsBatchQueryRequest]
142142
:return: BatchResponse, or the result of cls(response)
143-
:rtype: ~list[~azure.monitor.query.LogsQueryResult]
143+
:rtype: ~list[~azure.monitor.query.LogsBatchQueryResult]
144144
:raises: ~azure.core.exceptions.HttpResponseError
145145
146146
.. admonition:: Example:
@@ -165,7 +165,7 @@ def batch_query(self, queries, **kwargs):
165165
return order_results(
166166
request_order,
167167
[
168-
LogsQueryResult._from_generated(rsp) for rsp in generated.responses # pylint: disable=protected-access
168+
LogsBatchQueryResult._from_generated(rsp) for rsp in generated.responses # pylint: disable=protected-access
169169
])
170170

171171
def close(self):

sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def __init__(self, **kwargs):
6464
self.type = kwargs.get("type", None)
6565

6666

67-
class LogsQueryResults(object):
67+
class LogsQueryResult(object):
6868
"""Contains the tables, columns & rows resulting from a query.
6969
7070
:keyword tables: The list of tables, columns and rows.
@@ -206,15 +206,15 @@ def __init__(self, query, workspace_id, duration=None, **kwargs): #pylint: disab
206206
self.headers = headers
207207
self.workspace = workspace_id
208208

209-
class LogsQueryResult(object):
210-
"""The LogsQueryResult.
209+
class LogsBatchQueryResult(object):
210+
"""The LogsBatchQueryResult.
211211
212212
:param id:
213213
:type id: str
214214
:param status:
215215
:type status: int
216216
:param body: Contains the tables, columns & rows resulting from a query.
217-
:type body: ~azure.monitor.query.LogsQueryResults
217+
:type body: ~azure.monitor.query.LogsQueryResult
218218
"""
219219
def __init__(
220220
self,
@@ -231,7 +231,7 @@ def _from_generated(cls, generated):
231231
return cls(
232232
id=generated.id,
233233
status=generated.status,
234-
body=LogsQueryResults._from_generated(generated.body) # pylint: disable=protected-access
234+
body=LogsQueryResult._from_generated(generated.body) # pylint: disable=protected-access
235235
)
236236

237237

sdk/monitor/azure-monitor-query/azure/monitor/query/aio/_log_query_client_async.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
from .._generated.models import BatchRequest, QueryBody as LogsQueryBody
1414
from .._helpers import process_error, construct_iso8601, order_results
15-
from .._models import LogsQueryResults, LogsBatchQueryRequest, LogsQueryResult
15+
from .._models import LogsQueryResult, LogsBatchQueryRequest, LogsBatchQueryResult
1616
from ._helpers_asyc import get_authentication_policy
1717

1818
if TYPE_CHECKING:
@@ -43,7 +43,7 @@ async def query(
4343
workspace_id: str,
4444
query: str,
4545
duration: Optional[timedelta] = None,
46-
**kwargs: Any) -> LogsQueryResults:
46+
**kwargs: Any) -> LogsQueryResult:
4747
"""Execute an Analytics query.
4848
4949
Executes an Analytics query for data.
@@ -74,7 +74,7 @@ async def query(
7474
These can be qualified workspace names, workspsce Ids or Azure resource Ids.
7575
:paramtype additional_workspaces: list[str]
7676
:return: QueryResults, or the result of cls(response)
77-
:rtype: ~azure.monitor.query.LogsQueryResults
77+
:rtype: ~azure.monitor.query.LogsQueryResult
7878
:raises: ~azure.core.exceptions.HttpResponseError
7979
"""
8080
start = kwargs.pop('start_time', None)
@@ -105,7 +105,7 @@ async def query(
105105
)
106106

107107
try:
108-
return LogsQueryResults._from_generated(await self._query_op.execute( # pylint: disable=protected-access
108+
return LogsQueryResult._from_generated(await self._query_op.execute( # pylint: disable=protected-access
109109
workspace_id=workspace_id,
110110
body=body,
111111
prefer=prefer,
@@ -118,7 +118,7 @@ async def batch_query(
118118
self,
119119
queries: Union[Sequence[Dict], Sequence[LogsBatchQueryRequest]],
120120
**kwargs: Any
121-
) -> Sequence[LogsQueryResult]:
121+
) -> Sequence[LogsBatchQueryResult]:
122122
"""Execute a list of analytics queries. Each request can be either a LogQueryRequest
123123
object or an equivalent serialized model.
124124
@@ -127,7 +127,7 @@ async def batch_query(
127127
:param queries: The list of queries that should be processed
128128
:type queries: list[dict] or list[~azure.monitor.query.LogsBatchQueryRequest]
129129
:return: BatchResponse, or the result of cls(response)
130-
:rtype: ~list[~azure.monitor.query.LogsQueryResult]
130+
:rtype: ~list[~azure.monitor.query.LogsBatchQueryResult]
131131
:raises: ~azure.core.exceptions.HttpResponseError
132132
"""
133133
try:
@@ -143,7 +143,7 @@ async def batch_query(
143143
return order_results(
144144
request_order,
145145
[
146-
LogsQueryResult._from_generated(rsp) for rsp in generated.responses # pylint: disable=protected-access
146+
LogsBatchQueryResult._from_generated(rsp) for rsp in generated.responses # pylint: disable=protected-access
147147
])
148148

149149
async def __aenter__(self) -> "LogsQueryClient":

sdk/monitor/azure-monitor-query/samples/async_samples/sample_log_query_client_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ async def logs_query():
2222
where TimeGenerated > ago(12h) |
2323
summarize avgRequestDuration=avg(DurationMs) by bin(TimeGenerated, 10m), _ResourceId"""
2424

25-
# returns LogsQueryResults
25+
# returns LogsQueryResult
2626
async with client:
2727
response = await client.query(os.environ['LOG_WORKSPACE_ID'], query)
2828

sdk/monitor/azure-monitor-query/samples/sample_log_query_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
end_time = datetime.now(UTC())
2424

25-
# returns LogsQueryResults
25+
# returns LogsQueryResult
2626
response = client.query(os.environ['LOG_WORKSPACE_ID'], query, duration=timedelta(days=1), end_time=end_time)
2727

2828
if not response.tables:

sdk/monitor/azure-monitor-query/samples/sample_log_query_client_without_pandas.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
end_time = datetime.now(UTC())
2020

21-
# returns LogsQueryResults
21+
# returns LogsQueryResult
2222
response = client.query(os.environ['LOG_WORKSPACE_ID'], query, duration=timedelta(hours=1), end_time=end_time)
2323

2424
if not response.tables:

sdk/monitor/azure-monitor-query/samples/sample_log_query_multiple_workspaces.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
end_time = datetime.now(UTC())
2020

21-
# returns LogsQueryResults
21+
# returns LogsQueryResult
2222
response = client.query(
2323
os.environ['LOG_WORKSPACE_ID'],
2424
query,

0 commit comments

Comments
 (0)