Add AppInsights to CLI client factory (Azure#15220)

* Add AppInsights to CLI client factory

* Read AppInsights cloud definition from CLI

* ChangeLog

Author: lmazuel

sdk/core/azure-common/CHANGELOG.md

@@ -1,7 +1,8 @@
 # Release History
 
-## 1.1.26 (Unreleased)
+## 1.1.26 (2020-11-10)
 
+- get_client_from_cli_profile now supports azure-applicationinsights 0.1.0 package
 
 ## 1.1.25 (2020-03-09)
 

sdk/core/azure-common/azure/common/client_factory.py

@@ -38,6 +38,8 @@ def _client_resource(client_class, cloud):
     """
     if client_class.__name__ == 'GraphRbacManagementClient':
         return cloud.endpoints.active_directory_graph_resource_id, cloud.endpoints.active_directory_graph_resource_id
+    if client_class.__name__ == 'ApplicationInsightsDataClient':
+        return cloud.endpoints.app_insights_resource_id, cloud.endpoints.app_insights_resource_id+"/v1"
     if client_class.__name__ == 'KeyVaultClient':
         vault_host = cloud.suffixes.keyvault_dns[1:]
         vault_url = 'https://{}'.format(vault_host)

sdk/core/azure-common/setup.py

@@ -63,11 +63,11 @@
         'Programming Language :: Python :: 2',
         'Programming Language :: Python :: 2.7',
         'Programming Language :: Python :: 3',
-        'Programming Language :: Python :: 3.4',
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
         'Programming Language :: Python :: 3.8',
+        'Programming Language :: Python :: 3.9',
         'License :: OSI Approved :: MIT License',
     ],
     zip_safe=False,

sdk/core/azure-common/tests/test_client_factory.py

@@ -17,6 +17,8 @@
 from io import open
 
 from msrestazure.azure_cloud import AZURE_PUBLIC_CLOUD
+# https://github.com/Azure/azure-cli/blob/4e1ff0ec626ea46d74793ad92a1b5eddc2b6e45b/src/azure-cli-core/azure/cli/core/cloud.py#L310
+AZURE_PUBLIC_CLOUD.endpoints.app_insights_resource_id='https://api.applicationinsights.io'
 
 from azure.common.client_factory import *
 
@@ -64,6 +66,16 @@ def __init__(self, credentials, tenant_id, base_url):
                 self.tenant_id = tenant_id
                 self.base_url = base_url
 
+        class ApplicationInsightsDataClient(object):
+            def __init__(self, credentials, base_url):
+                if credentials is None:
+                    raise ValueError("Parameter 'credentials' must not be None.")
+                if not base_url:
+                    base_url = 'should not be used'
+
+                self.credentials = credentials
+                self.base_url = base_url
+
         class KeyVaultClient(object):
             def __init__(self, credentials):
                 if credentials is None:
@@ -91,6 +103,11 @@ def __init__(self, credentials):
         assert client.tenant_id == 'tenant_id'
         assert client.base_url == "https://graph.windows.net/"
 
+        client = get_client_from_cli_profile(ApplicationInsightsDataClient)
+        get_azure_cli_credentials.assert_called_with(resource="https://api.applicationinsights.io", with_tenant=True)
+        assert client.credentials == 'credentials'
+        assert client.base_url == "https://api.applicationinsights.io/v1"
+
         client = get_client_from_cli_profile(KeyVaultClient)
         get_azure_cli_credentials.assert_called_with(resource="https://vault.azure.net", with_tenant=True)
         assert client.credentials == 'credentials'