Skip to content

Commit 87e0f99

Browse files
Sync eng/common directory with azure-sdk-tools for PR 2016 (Azure#20706)
* Make ServiceName optional for verify-changelog In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty. * Put quotes around the strings to allow for empty Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
1 parent c80e26e commit 87e0f99

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

eng/common/pipelines/templates/steps/verify-changelog.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ parameters:
44
default: 'not-specified'
55
- name: ServiceName
66
type: string
7-
default: 'not-specified'
7+
default: ''
88
- name: ServiceDirectory
99
type: string
1010
default: ''
@@ -17,10 +17,10 @@ steps:
1717
inputs:
1818
filePath: $(Build.SourcesDirectory)/eng/common/scripts/Verify-ChangeLog.ps1
1919
arguments: >
20-
-PackageName ${{ parameters.PackageName }}
21-
-ServiceDirectory ${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }}
20+
-PackageName '${{ parameters.PackageName }}'
21+
-ServiceDirectory '${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }}'
2222
-ForRelease $${{ parameters.ForRelease }}
2323
pwsh: true
2424
workingDirectory: $(Pipeline.Workspace)
2525
displayName: Verify ChangeLogEntry for ${{ parameters.PackageName }}
26-
continueOnError: false
26+
continueOnError: false

0 commit comments

Comments
 (0)