[Storage] Address comments from API Review for March release (Azure#23294)

Author: jalauzon-msft

sdk/storage/azure-storage-blob/azure/storage/blob/_models.py

@@ -923,7 +923,7 @@ class ContainerSasPermissions(object):
         Write a new blob, snapshot a blob, or copy a blob to a new blob.
     :keyword bool permanent_delete:
         To enable permanent delete on the blob is permitted.
-    :keyword bool find:
+    :keyword bool filter_by_tags:
         To enable finding blobs by tags.
     :keyword bool move:
         Move a blob or a directory and its contents to a new location.
@@ -945,7 +945,7 @@ def __init__(self, read=False, write=False, delete=False,
         self.permanent_delete = kwargs.pop('permanent_delete', False)
         self.list = list
         self.tag = tag
-        self.find = kwargs.pop('find', False)
+        self.filter_by_tags = kwargs.pop('filter_by_tags', False)
         self.move = kwargs.pop('move', False)
         self.execute = kwargs.pop('execute', False)
         self.set_immutability_policy = kwargs.pop('set_immutability_policy', False)
@@ -958,7 +958,7 @@ def __init__(self, read=False, write=False, delete=False,
                      ('y' if self.permanent_delete else '') +
                      ('l' if self.list else '') +
                      ('t' if self.tag else '') +
-                     ('f' if self.find else '') +
+                     ('f' if self.filter_by_tags else '') +
                      ('m' if self.move else '') +
                      ('e' if self.execute else '') +
                      ('i' if self.set_immutability_policy else ''))
@@ -988,14 +988,14 @@ def from_string(cls, permission):
         p_permanent_delete = 'y' in permission
         p_list = 'l' in permission
         p_tag = 't' in permission
-        p_find = 'f' in permission
+        p_filter_by_tags = 'f' in permission
         p_move = 'm' in permission
         p_execute = 'e' in permission
         p_set_immutability_policy = 'i' in permission
         parsed = cls(read=p_read, write=p_write, delete=p_delete, list=p_list,
                      delete_previous_version=p_delete_previous_version, tag=p_tag, add=p_add,
-                     create=p_create, permanent_delete=p_permanent_delete, find=p_find, move=p_move,
-                     execute=p_execute, set_immutability_policy=p_set_immutability_policy)
+                     create=p_create, permanent_delete=p_permanent_delete, filter_by_tags=p_filter_by_tags,
+                     move=p_move, execute=p_execute, set_immutability_policy=p_set_immutability_policy)
 
         return parsed
 

sdk/storage/azure-storage-blob/tests/test_common_blob.py

@@ -1839,7 +1839,7 @@ def test_blob_service_sas(self, storage_account_name, storage_account_key):
             account_key=container.credential.account_key,
             permission=ContainerSasPermissions(
                 read=True, write=True, delete=True, list=True, delete_previous_version=True,
-                tag=True, add=True, create=True, permanent_delete=True, find=True, move=True,
+                tag=True, add=True, create=True, permanent_delete=True, filter_by_tags=True, move=True,
                 execute=True, set_immutability_policy=True
             ),
             expiry=datetime.utcnow() + timedelta(hours=1),
@@ -1853,7 +1853,7 @@ def test_blob_service_sas(self, storage_account_name, storage_account_key):
             account_key=blob.credential.account_key,
             permission=BlobSasPermissions(
                 read=True, add=True, create=True, write=True, delete=True, delete_previous_version=True,
-                permanent_delete=True, tag=True, find=True, move=True, execute=True, set_immutability_policy=True
+                permanent_delete=True, tag=True, move=True, execute=True, set_immutability_policy=True
             ),
             expiry=datetime.utcnow() + timedelta(hours=1),
         )

sdk/storage/azure-storage-blob/tests/test_container.py

@@ -1255,7 +1255,7 @@ def test_find_blobs_by_tags_container_sas(self, storage_account_name, storage_ac
             container.account_name,
             container.container_name,
             account_key=storage_account_key,
-            permission=ContainerSasPermissions(find=True),
+            permission=ContainerSasPermissions(filter_by_tags=True),
             expiry=datetime.utcnow() + timedelta(hours=1)
         )
         container = ContainerClient.from_container_url(container.url, credential=sas_token)

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_directory_client.py

@@ -367,7 +367,7 @@ def rename_directory(
         :keyword file_last_write_time:
             Last write time for the file.
         :paramtype file_last_write_time:~datetime.datetime or str
-        :keyword dict(str,str) metadata:
+        :keyword Dict[str,str] metadata:
             A name-value pair to associate with a file storage object.
         :keyword lease:
             Required if the destination file has an active lease. Value can be a ShareLeaseClient object
@@ -632,7 +632,8 @@ def exists(self, **kwargs):
 
         :kwarg int timeout:
             The timeout parameter is expressed in seconds.
-        :returns: boolean
+        :returns: True if the directory exists, False otherwise.
+        :rtype: bool
         """
         try:
             self._client.directory.get_properties(**kwargs)

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_file_client.py

@@ -834,7 +834,7 @@ def rename_file(
         :keyword file_last_write_time:
             Last write time for the file.
         :paramtype file_last_write_time:~datetime.datetime or str
-        :keyword dict(str,str) metadata:
+        :keyword Dict[str,str] metadata:
             A name-value pair to associate with a file storage object.
         :keyword source_lease:
             Required if the source file has an active lease. Value can be a ShareLeaseClient object

sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_directory_client_async.py

@@ -247,7 +247,7 @@ async def rename_directory(
         :keyword file_last_write_time:
             Last write time for the file.
         :paramtype file_last_write_time:~datetime.datetime or str
-        :keyword dict(str,str) metadata:
+        :keyword Dict[str,str] metadata:
             A name-value pair to associate with a file storage object.
         :keyword lease:
             Required if the destination file has an active lease. Value can be a ShareLeaseClient object
@@ -377,7 +377,8 @@ async def exists(self, **kwargs):
 
         :kwarg int timeout:
             The timeout parameter is expressed in seconds.
-        :returns: boolean
+        :returns: True if the directory exists, False otherwise.
+        :rtype: bool
         """
         try:
             await self._client.directory.get_properties(**kwargs)

sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_file_client_async.py

@@ -710,7 +710,7 @@ async def rename_file(
         :keyword file_last_write_time:
             Last write time for the file.
         :paramtype file_last_write_time:~datetime.datetime or str
-        :keyword dict(str,str) metadata:
+        :keyword Dict[str,str] metadata:
             A name-value pair to associate with a file storage object.
         :keyword source_lease:
             Required if the source file has an active lease. Value can be a ShareLeaseClient object