Skip to content

Commit 7368ddf

Browse files
[metricsadvisor] fix sample/readme issues (Azure#15854)
Resolves Azure#15845
1 parent 5792b5b commit 7368ddf

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

sdk/metricsadvisor/azure-ai-metricsadvisor/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ Metrics Advisor lets you create and subscribe to real-time alerts. These alerts
116116
Metrics Advisor supports connecting different types of data sources. Here is a sample to ingest data from SQL Server.
117117

118118
```py
119+
import os
120+
import datetime
119121
from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorAdministrationClient
120122
from azure.ai.metricsadvisor.models import (
121123
SQLServerDataFeed,
@@ -124,6 +126,7 @@ from azure.ai.metricsadvisor.models import (
124126
DataFeedDimension,
125127
DataFeedOptions,
126128
DataFeedRollupSettings,
129+
DataFeedMissingDataPointFillSettings
127130
)
128131

129132
service_endpoint = os.getenv("ENDPOINT")
@@ -410,7 +413,6 @@ for result in results:
410413
We can also query the root causes of an incident
411414

412415
```py
413-
import datetime
414416
from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorClient
415417

416418
service_endpoint = os.getenv("ENDPOINT")

sdk/metricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_alert_configuration_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ async def main():
315315
print("\n---List anomaly alert configurations...")
316316
await sample_list_alert_configs_async()
317317
print("\n---Query anomaly detection results...")
318-
alerts = await sample_list_alerts_async()
318+
alerts = await sample_list_alerts_async(alert_config.id)
319319
if len(alerts) > 0:
320320
print("\n---Query anomalies using alert id...")
321321
alert_id = alerts[0].id

sdk/metricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_authentication_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ async def authentication_client_with_metrics_advisor_credential_async():
4040
# [END authentication_client_with_metrics_advisor_credential_async]
4141

4242

43-
def authentication_administration_client_with_metrics_advisor_credential_async():
43+
async def authentication_administration_client_with_metrics_advisor_credential_async():
4444
# [START administration_client_with_metrics_advisor_credential_async]
4545
from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential
4646
from azure.ai.metricsadvisor.aio import MetricsAdvisorAdministrationClient

sdk/metricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_feedback_async.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ async def sample_add_feedback_async():
7373

7474
async def sample_get_feedback_async():
7575
# [START get_feedback_async]
76-
from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorClient
76+
from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential
77+
from azure.ai.metricsadvisor.aio import MetricsAdvisorClient
7778

7879
service_endpoint = os.getenv("METRICS_ADVISOR_ENDPOINT")
7980
subscription_key = os.getenv("METRICS_ADVISOR_SUBSCRIPTION_KEY")
@@ -90,7 +91,8 @@ async def sample_get_feedback_async():
9091

9192
async def sample_list_feedback_async():
9293
# [START list_feedback_async]
93-
from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential, MetricsAdvisorClient
94+
from azure.ai.metricsadvisor import MetricsAdvisorKeyCredential
95+
from azure.ai.metricsadvisor.aio import MetricsAdvisorClient
9496

9597
service_endpoint = os.getenv("METRICS_ADVISOR_ENDPOINT")
9698
subscription_key = os.getenv("METRICS_ADVISOR_SUBSCRIPTION_KEY")

sdk/metricsadvisor/azure-ai-metricsadvisor/samples/sample_alert_configuration.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,11 +188,13 @@ def sample_list_alerts(alert_config_id):
188188
end_time=datetime.datetime(2020, 9, 9),
189189
time_mode="AnomalyTime",
190190
)
191+
192+
tolist = []
191193
for result in results:
194+
tolist.append(result)
192195
print("Alert id: {}".format(result.id))
193196
print("Create on: {}".format(result.created_on))
194-
return results
195-
197+
return tolist
196198
# [END list_alerts]
197199

198200

0 commit comments

Comments
 (0)