address arch board review feedback (Azure#19004)

* address arch board review feedback

Author: xiangyan99

sdk/metricsadvisor/azure-ai-metricsadvisor/CHANGELOG.md

@@ -3,29 +3,32 @@
 ## 1.0.0b4 (2021-06-07)
 
 **New Features**
-- Added AzureLogAnalyticsDataFeedSource and AzureEventHubsDataFeedSource
+- Added `AzureLogAnalyticsDataFeedSource` and `AzureEventHubsDataFeedSource`
 - Update method now returns the updated object
-- Added CredentialEntities and CredentialEntity operations
+- Added DatasourceCredentials and DatasourceCredential operations
 - Added authentication type support for data feed
 
 **Breaking Changes**
 
+- Delete methods now take positional only argument as id.
+- `update_subscription_key` and `update_api_key` are merged into one method `update_key`
+
 - Deprecated:
-    - HttpRequestDataFeed
-    - ElasticsearchDataFeed
+    - `HttpRequestDataFeed`
+    - `ElasticsearchDataFeed`
 
 - Renamed
-    - AzureApplicationInsightsDataFeed -> AzureApplicationInsightsDataFeedSource
-    - AzureBlobDataFeed -> AzureBlobDataFeedSource
-    - AzureCosmosDBDataFeed -> AzureCosmosDbDataFeedSource
-    - AzureDataExplorerDataFeed -> AzureDataExplorerDataFeedSource
-    - AzureTableDataFeed -> AzureTableDataFeedSource
-    - InfluxDBDataFeed -> InfluxDbDataFeedSource
-    - MySqlDataFeed -> MySqlDataFeedSource
-    - PostgreSqlDataFeed -> PostgreSqlDataFeedSource
-    - SQLServerDataFeed -> SqlServerDataFeedSource
-    - MongoDBDataFeed -> MongoDbDataFeedSource
-    - AzureDataLakeStorageGen2DataFeed -> AzureDataLakeStorageGen2DataFeedSource
+    - `AzureApplicationInsightsDataFeed` -> `AzureApplicationInsightsDataFeedSource`
+    - `AzureBlobDataFeed` -> `AzureBlobDataFeedSource`
+    - `AzureCosmosDBDataFeed` -> `AzureCosmosDbDataFeedSource`
+    - `AzureDataExplorerDataFeed` -> `AzureDataExplorerDataFeedSource`
+    - `AzureTableDataFeed` -> `AzureTableDataFeedSource`
+    - `InfluxDBDataFeed` -> `InfluxDbDataFeedSource`
+    - `MySqlDataFeed` -> `MySqlDataFeedSource`
+    - `PostgreSqlDataFeed` -> `PostgreSqlDataFeedSource`
+    - `SQLServerDataFeed` -> `SqlServerDataFeedSource`
+    - `MongoDBDataFeed` -> `MongoDbDataFeedSource`
+    - `AzureDataLakeStorageGen2DataFeed` -> `AzureDataLakeStorageGen2DataFeedSource`
 
 **Dependency Updates**
 

sdk/metricsadvisor/azure-ai-metricsadvisor/azure/ai/metricsadvisor/_helpers.py

@@ -25,10 +25,10 @@
     CommentFeedback,
     PeriodFeedback,
     DataFeedRollupType,
-    SqlConnectionStringCredentialEntity,
-    DataLakeGen2SharedKeyCredentialEntity,
-    ServicePrincipalCredentialEntity,
-    ServicePrincipalInKeyVaultCredentialEntity
+    DatasourceSqlConnectionString,
+    DatasourceDataLakeGen2SharedKey,
+    DatasourceServicePrincipal,
+    DatasourceServicePrincipalInKeyVault
 )
 from ._metrics_advisor_key_credential import MetricsAdvisorKeyCredential
 from ._metrics_advisor_key_credential_policy import MetricsAdvisorKeyCredentialPolicy
@@ -226,11 +226,11 @@ def get_authentication_policy(credential):
 
     return authentication_policy
 
-def convert_to_credential_entity(credential_entity):
-    if credential_entity.data_source_credential_type == "AzureSQLConnectionString":
-        return SqlConnectionStringCredentialEntity._from_generated(credential_entity)
-    if credential_entity.data_source_credential_type == "DataLakeGen2SharedKey":
-        return DataLakeGen2SharedKeyCredentialEntity._from_generated(credential_entity)
-    if credential_entity.data_source_credential_type == "ServicePrincipal":
-        return ServicePrincipalCredentialEntity._from_generated(credential_entity)
-    return ServicePrincipalInKeyVaultCredentialEntity._from_generated(credential_entity)
+def convert_to_datasource_credential(datasource_credential):
+    if datasource_credential.data_source_credential_type == "AzureSQLConnectionString":
+        return DatasourceSqlConnectionString._from_generated(datasource_credential)
+    if datasource_credential.data_source_credential_type == "DataLakeGen2SharedKey":
+        return DatasourceDataLakeGen2SharedKey._from_generated(datasource_credential)
+    if datasource_credential.data_source_credential_type == "ServicePrincipal":
+        return DatasourceServicePrincipal._from_generated(datasource_credential)
+    return DatasourceServicePrincipalInKeyVault._from_generated(datasource_credential)