Fix type annotations and pylint overrides (Azure#18142)

Author: chlowell

sdk/identity/azure-identity/azure/identity/aio/_credentials/app_service.py

@@ -26,9 +26,7 @@ def __init__(self, **kwargs: "Any") -> None:
         else:
             self._available = False
 
-    async def get_token(  # pylint:disable=invalid-overridden-method
-        self, *scopes: str, **kwargs: "Any"
-    ) -> "AccessToken":
+    async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":
         if not self._available:
             raise CredentialUnavailableError(
                 message="App Service managed identity configuration not found in environment"
@@ -37,7 +35,7 @@ async def get_token(  # pylint:disable=invalid-overridden-method
         return await super().get_token(*scopes, **kwargs)
 
     async def close(self) -> None:
-        await self._client.close()  # pylint:disable=no-member
+        await self._client.close()
 
     async def _acquire_token_silently(self, *scopes: str) -> "Optional[AccessToken]":
         return self._client.get_cached_token(*scopes)

sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_arc.py

@@ -52,9 +52,7 @@ def __init__(self, **kwargs: "Any") -> None:
                 **kwargs
             )
 
-    async def get_token(  # pylint:disable=invalid-overridden-method
-        self, *scopes: str, **kwargs: "Any"
-    ) -> "AccessToken":
+    async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":
         if not self._available:
             raise CredentialUnavailableError(
                 message="Service Fabric managed identity configuration not found in environment"
@@ -63,7 +61,7 @@ async def get_token(  # pylint:disable=invalid-overridden-method
         return await super().get_token(*scopes, **kwargs)
 
     async def close(self) -> None:
-        await self._client.close()  # pylint:disable=no-member
+        await self._client.close()
 
     async def _acquire_token_silently(self, *scopes: str) -> "Optional[AccessToken]":
         return self._client.get_cached_token(*scopes)

sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_cli.py

@@ -5,6 +5,7 @@
 import asyncio
 import sys
 import os
+from typing import TYPE_CHECKING
 
 from azure.core.exceptions import ClientAuthenticationError
 from .._internal import AsyncContextManager
@@ -21,6 +22,10 @@
 )
 from ..._internal import _scopes_to_resource
 
+if TYPE_CHECKING:
+    from typing import Any
+    from azure.core.credentials import AccessToken
+
 
 class AzureCliCredential(AsyncContextManager):
     """Authenticates by requesting a token from the Azure CLI.
@@ -29,7 +34,7 @@ class AzureCliCredential(AsyncContextManager):
     """
 
     @log_get_token_async
-    async def get_token(self, *scopes, **kwargs):
+    async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":
         """Request an access token for `scopes`.
 
         This method is called automatically by Azure SDK clients. Applications calling this method directly must
@@ -60,7 +65,7 @@ async def close(self):
         """Calling this method is unnecessary"""
 
 
-async def _run_command(command):
+async def _run_command(command: str) -> str:
     if sys.platform.startswith("win"):
         args = ("cmd", "/c " + command)
     else:

sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py

@@ -17,6 +17,7 @@
 
 if TYPE_CHECKING:
     from typing import Any, List
+    from azure.core.credentials import AccessToken
     from azure.core.credentials_async import AsyncTokenCredential
 
 _LOGGER = logging.getLogger(__name__)
@@ -99,7 +100,6 @@ def __init__(self, **kwargs: "Any") -> None:
                 )
                 credentials.append(shared_cache)
             except Exception as ex:  # pylint:disable=broad-except
-                # transitive dependency pywin32 doesn't support 3.8 (https://github.com/mhammond/pywin32/issues/1431)
                 _LOGGER.info("Shared token cache is unavailable: '%s'", ex)
         if not exclude_visual_studio_code_credential:
             credentials.append(VisualStudioCodeCredential(tenant_id=vscode_tenant_id))
@@ -108,7 +108,7 @@ def __init__(self, **kwargs: "Any") -> None:
 
         super().__init__(*credentials)
 
-    async def get_token(self, *scopes: str, **kwargs: "Any"):
+    async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":
         """Asynchronously request an access token for `scopes`.
 
         This method is called automatically by Azure SDK clients.

sdk/identity/azure-identity/azure/identity/aio/_credentials/service_fabric.py

@@ -26,9 +26,7 @@ def __init__(self, **kwargs: "Any") -> None:
         else:
             self._available = False
 
-    async def get_token(  # pylint:disable=invalid-overridden-method
-        self, *scopes: str, **kwargs: "Any"
-    ) -> "AccessToken":
+    async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":
         if not self._available:
             raise CredentialUnavailableError(
                 message="Service Fabric managed identity configuration not found in environment"
@@ -37,7 +35,7 @@ async def get_token(  # pylint:disable=invalid-overridden-method
         return await super().get_token(*scopes, **kwargs)
 
     async def close(self) -> None:
-        await self._client.close()  # pylint:disable=no-member
+        await self._client.close()
 
     async def _acquire_token_silently(self, *scopes: str) -> "Optional[AccessToken]":
         return self._client.get_cached_token(*scopes)

sdk/identity/azure-identity/azure/identity/aio/_credentials/vscode.py

@@ -48,8 +48,7 @@ async def close(self):
         if self._client:
             await self._client.__aexit__()
 
-    async def get_token(self, *scopes, **kwargs):
-        # type: (*str, **Any) -> AccessToken
+    async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":
         """Request an access token for `scopes` as the user currently signed in to Visual Studio Code.
 
         This method is called automatically by Azure SDK clients.