leave comment for credscan suppression, add value to ignored secrets (Azure#22942)

Author: iscai-msft

eng/CredScanSuppression.json

@@ -33,6 +33,7 @@
                 "pass$w0rd",
                 "MIIJsQIBAzCCCXcGCSqGSIb3DQEHAaCCCWgEgglkMIIJYDCCBBcGCSqGSIb3DQEHBqCCBAgwggQEAgEAMIID/QYJKoZIhvcNAQcBMBwGCiqGSIb3DQEMAQYwDgQIWLKMqe2DMNcCAggAgIID0NfyQXWkGMtMjCa9BwG2Q61zZbbGQyCoNe59yTw2dVWbA3hLuMaOxrsS+5YDiRVhy/815WnsS25xR4ju2WN96j8ZF70DNYfyT18SLRpKxa1mpPE1GKRDYoax9Sy4syduWJwYGc6/+rBnIRogebE7fKlA5ZCSseB2SkQG93ysmhFrhkps4UvaYbCyR1leuT7bOWAbXn7Ztet46Jz4WKun5NyKIXtWpkO8sgsy20uuQkqSjWVuOKa6nCRkZ5iY/kb3AkWRqK7snBt994A21kKG8fZU670Dw1s3tixtLlE2WDwYnb3fULJzmtTXYkyaRFbWoFJPHrPMu9K9ZQTY/WXTcFSj2qgQUl05SQOBiJo7bn1kVT+XTTrCP5OELO0vvaIUV9omMwua9oUegWgS0GkADhvc7g2PkJw5ugoW23MFrLPU7Jt2MLXnBF3dhu6xkf7NMGCa0330On2oAy4ru3jsIqKkrxwz26uRrDz4Zy2G3lUbcPaP7T7IYdu44E/139dNxHZvoGuRFqWISbj5nkY5pcQUrgGZOpOe9ygmOSeUVY7dIJxFKW7X1O3Nl4LpoaKW42nTM7xuoVQ4O/GgapHqvgyKjiSzL9zrRZAXEprKQAQMCbreYmuzeJoXOugqYE9wHpEnePWpK7GpA+0wAJ3gsqFEaLS6PAUXNapX5af9VPrZenBBYFUIxPUn4uJz+p2PGMWA90H4OXv4eTlQ2lqqEqDYZ5MuwtIwt6vH1FO7h2GqiMbVN/ckTSpkFKaUbsiqESKfzD712YyNKmsKKU09e2c3SagCCW8zIj7kgsraDcKuvqOqjnMSXlxo+MgNcaYySHAzNDxL94Wy7sOIGogZmTEDEVdPvmdZQ5TKtan3YwvsUx5mtxU9t1uQIilK7PIbf1RrQimq6UXpQkatc1r1t+Ngwy2ZniZzwakuVc4DkWq0eaDHjR2S5a1WZtAc8UIHM/EQNcVZaQejBjR7QJmPY5eTgmE+7IbQMbn88nNdElKipmlqS3c6wO57L0zRSvbrBCxUuVI4BzdVfREuxm+Kev1paAS44rcygRzsRGr9gEoee/I6VgNbGjCV08H8UiF5K0/VbN93+EtaefNQBaU0fFLZUf1nxMgtgTJKqU2ku/d6R82B/4LWCDnvXABVCQ+1WmB5jXUzwYAFVXHqpZbGdE7qK663GRvT0CIN2FwljZMTtYNXCQO6TlseVLX8CrLdxGioJol85NWrj3YSD//gG3Ds0RiH+0fXcuN67in2RC3WKfaUCcUTur71Tau2f37SWZ9FrzOHQqJVoP/dKTG1UJ8wggVBBgkqhkiG9w0BBwGgggUyBIIFLjCCBSowggUmBgsqhkiG9w0BDAoBAqCCBO4wggTqMBwGCiqGSIb3DQEMAQMwDgQIAMlOFXUURPECAggABIIEyFYuslCPqytr0m3AvBpTJMm3Umv94Xg6z+lhl6oQ/ClfV7TBaUb1gvM12z7+hSbuyZfFJwm/rK5c28BHVpZL5zvehnhRALjt67yIEVhMmnqeSv9PIR7F1rzrGBGXle3i2MCzDQD3+QRD/m3HUF/WD9LLx9Q0ucUfdz4i0q07IbRAC1DP/xkmA2uqi/zWWIdec31tdqbyR7tA2hUyXXpVG5ZxxyHuwlEFZEcHpsHnDU405ih45+WhcA+R7CM6bwzLsRf1TZ7Ljx3Fw848G0Q6k4OvOmRyWtCAP/soJCPvuOXnIvJXOJNkDtv5FyoQF+xya9gfb6a+t/kbwHFhM14t6ryCZ525f86PEizcfijTDvdE2E1EqFZlbnBVCHwJ9eJucjSxXmpgslbdroNHZpMNA+bDZiqgcgcOHPK+MaE7KEoiRKkJ7Q4T3XWfrLqDaAtFmhINJw7HmSueliyOEM9HvVHa8CKA1IM8xdF/nrsGEYrw/GUtPaF1ZXEBoeFO1yH+6JkT2SyGbzei2KACShquZpFqJvH6gStxZP5oaOT0UIE2EKz9+2peTahE5XL3L7Xmq/UqezsRKOBBsR+uTSB6w8dWmweaaloBML1iRsNJLDFtZPJvi7zWMq0xjUxoL3ulMJ8jP2/u1mum0lylO26IFqg7V744gSt1FPHR62zwG2zV2b5hu1/hNnhXeE9KMsdwwdfLUkcqXrNBBqkDjF12S4rt7HCaAjx1fE/O/oMqC8YEO3TYa7mL4maj7lR9Ja0n7gVHpKGIy6IUevadPhxcvM1/dMaxO/hd4xCDQC1V8BYqxsv6QH4dbxOj3YTuxD7mRUSI7m4gQbG2jDlUYTWMdCaQow2RCPBE7JWk7efvX/RwknQXi26TcGsVhAZ0/5Tf2+KP0pOBZ5Y+4sQcbSBIXTQqTR4+qTEmTosSj4OTDOO6bS+bVnmsaNAJ9OVa9bNAXSOl+6WPEjNR3z42W/fd+sUk0Y0GU4YcNiBIfMPkkQksVmqU3Y0yyuazrZkk/32kqSrONfxV9JbkgLGwS4O2LBDCubxHyBoakqLvjyFie/jYp7Hu4R6XEfD0mgpho6hhWHh7gy54yA/RiKoZZ7IyJv14KbFzs0f8PEbSx75RpfVEtQD+RZyIby7ompwRnHLvw04gj0kWy1MR84QUIL7yoJJIOgL6Kcgci4M5ZaVdcNAr0CdmjNKfOB7DIvDSxClZjL94zObKxsnExamxs593HLkKJkEdhskpPmaqL/Tt3IaLqxuJsFz7iI2KPRwD9N9mfE9Sfc9yvJiL53Q3sZq9j3oq1bUYa1ubbv0+4Fj3Swg4FmNz7TCN7swtb2BRnwTLh9CRN3BgWaRPIOxmCeosl1GzqWv+sN/GbKeJ8Nylmk1NzaVeJg0NkK2T9hlstVfmdRm+Xk4V30pG/FD67251T1vkLCHP6DJysoEGsfiS2OM+/x3onMvrB6T+hfUmtvxKcnQ7d4DMfmHC9wj/YZkULLYIa+sd9Pbr1U2mJ6lqyWsPUM7XLDMfzN1XOgIDuzcYxTRR5TDiYyg9hYksMNeqSisCsy/ODtMKwk73m2+0GdvIGbPQfV7cgGBEBzN9Wh2BLWtsZq107ZerM02XmRFmq/MX0TaOsmVXhTElMCMGCSqGSIb3DQEJFTEWBBTsd3zCMw1XrWC/MBjgt8IbFbCL8jAxMCEwCQYFKw4DAhoFAAQULqAXFUm78ZQ7CCRuYcS3O9qq21EECJq6mOwqNtpgAgIIAA==",
                 "MIIJsQIBAzCCCXcGCSqGSIb3DQEHAaCCCWgEgglkMIIJYDCCBBcGCSqGSIb3DQEHBqCCBAgwggQEAgEAMIID/QYJKoZIhvcNAQcBMBwGCiqGSIb3DQEMAQYwDgQIE7pdl4fTqmwCAggAgIID0MDlcRFQUH0YDxopuqVyuEd4OLfawucEAxGvdj9+SMs34Cz1tVyZgfFuU4MwlLk6cA1dog8iw9/f8/VlA6wS0DHhslLL3JzSxZoi6JQQ0IYgjWaIv4c+wT0IcBhc2USI3lPqoqALG15qcs8fAEpDIssUplDcmA7gLVvBvw1utAipib8y93J71tIIedDaf0pAuVuC6K1PRI3HWVnUetCaiq4AW2iQu7f0rxJVDcKubmNinEivyRi4yl2Q1g2OwGlqwZEAnIW02uE+FzgFk51OA357vvooKicb0fdDz+hsRuzlWMhs2ciFMg71jlCUIKnvAKXCR714ox+OK8pTN1KQy3ICAFy+m6lNpkwkozfRoMwJyRGt5Tm6N/k9nQM1ysu3xqw3hG8q4srCbWhxcUrvrDcxvWe5Q8WX8Sl8nJ4joPZipBxDSEKYPqk9qkPF+YZbAmjcS3mw0AI5V8v31WQaa/i6LxQGwKUVSyjHe6ZDskQjyogtRmt61z1MYHmv9iNuLyyWhq9w7hV/AyKTzQ7FsWcK2vdNZJA2lj8H7rSrYtaVFNPMBzOa4KsJmif9s9B0VyMlX37XB1tGEtRmRuJtA+EZYVzu50J/ZVx2QGr40IpmyYKwB6CTQpBE12W9RMgMLYy+YAykrexYOJaIh9wfzLi/bAH8uCNTKueeVREnMHrzSF1xNQzqW8okoEMvSdr6+uCjHxt1cmRhUOcGvocLfNOgNhz+qwztLr35QTE8zTnrjvhb0NKfT1vpGa0nXP3EBYDolRqTZgKlG9icupDI57wDNuHED/d63Ri+tCbs3VF+QjcPBO8q3xz0hMj38oYLnHYt1i4YQOvXSDdZLc4fW5GXB1cVmP9vxbM0lxBKCLA8V0wZ8P341Dknr5WhS21A0qs3b9FavwbUUCDTuvky/1qhA6MaxqbtzjeVm7mYJ7TnCQveH0Iy3RHEPQrzrGUQc0bEBfissGeVYlghNULlaDW9CobT6J+pYT0y85flg+qtTZX69NaI4mZuh11hkKLmbVx6gGouQ79XmpE3+vNycEQNota534gUs77qF0VACJHnbgh05Qhxkp9Xd/LSUt+6r9niTa9HWQ+SMdfXuu6ognA3lMGeO4i0NTFkXA1MNs+e0QQZqNX8CiCj09i6YeMNVTdIh1ufrEF9YlO8yjLitHVSJRuY65QCCpPsS5Ugdk+5tUD3H2l1j/ZA5f73z2JdFEAchPRLsNQKTx49ZvsSex2ikEJeNjHDBuMQZtVZZDs9DdVQL/i49Mc7N+/x37AcLFx+DelOKZ0F5LgiDDprfU8wggVBBgkqhkiG9w0BBwGgggUyBIIFLjCCBSowggUmBgsqhkiG9w0BDAoBAqCCBO4wggTqMBwGCiqGSIb3DQEMAQMwDgQIwQ83ZA6tJFoCAggABIIEyHQt53aY9srYggLfYUSeD6Gcjm7uEA5F24s9r3FZF50YRSztbJIrqGd6oytw4LDCInANcGuCF3WQjSdEB6ABy+Igmbk9OAsFAy18txfg05UQb4JYN3M0XkYywh+GlMlZdcsZQakXqBGSj6kyG4J9ISgGPpvSqopo7fUHjc3QjWcG07d42u6lgkLxdQH2e+qiHWA+9C3mawA5AYWA6sciEoKzYOZkl7ZtWptpJJWD54HtIT7ENGkHM6y2LM+FyMC0axoUsFawoObzcbJLX29Zfohzq9yt169ZLcKDC1zpS6R0MIRE5rs4727vG9mJWMetDpIg/2fka4nkhfry2Wo+Pp/065aUSfHbQGMZ2Lw/zgU1Eo/Bau+fREft/DRX/sZpkd0ulPlbxmQ80Xf6IXRSGD5poq3B19dJpKHmJagFJu1IgXEovjpexrYEmEAuzLaH1wdMTMGViWHsxu+g066LuHbBfJQ4THnAOp0N2eUkcfO3oJ3thzGnvWXM4lKAkULcnBlQnnfKi2CrQYJCJMhyIicYYs+03gxXxNwQihZPm3VI3an/ci1otoh19WP4on3DqZ4KySU+PZ45XzDg1H00+nhyShwuyiFhDN6XuJ0VWIZZEvoPRY1Tmt2prP/1B1Kk9+lishvTJKkuZ3rqC1bkJioIWte1FEoktCtzQ3dVUwlvy1r2y1WL5OTdk6yIENvm9+xHSkJelkZjW+Jr/B9dyZ2o9+oJGuLW8J2gNixecnWJXlb/tPwmL7iwLmFfM5tw27LnYO54dfUnq00G5JM6yiAj9i73RLkZo4lq29HOsoi4T3s06KpkOVhrIud7VhPFdzWtptcV9gbidHKtX209oZKAVgXa538DyKownqHx3I8yjXs0eFlty1CJjBP9fuAvllyNpUteuZoDcS45Zwl3WOpPrL595gBwy5yGOADOJXA3ww2oqvlTcZv1lyteKght3hMkSgy2mIGYAa19v+ZK0LxKxvwCCkC+bMuyTduiaUJmHmI7k0lVIt/5WPzz9cnvCahhCovN/+C0LI1xbOTW9nDp2Ffsb0aC9XYBRf/amRCiHmMzB18E85aA05h3l7KXPdck/xrKEePdv4dnLWxvHw69O6sjssmdV3q6+cZgYYLZAEl1byIbZBTQaHT0GhzcmHJrW71L6Sl/9TEfmDSvctEEe4cZd8o29TXqzE10kmrt8dqoRbYiNq5CODPiithVtCRWQu3aFoLkT0ooWEYk+IWU6/WQ8rq7KkZ6BR8JV60I3WbXLejTyaTf79VMt8myIET5GjSc7r+tWyDRCHcU32Guyw7F+9ndkMlVuI5gB/zfrsfX6noSQnx72yF6NrIyhJWf/Zl3NMbnPKUHA+sZkjE4+Hwvf5yWkjFZhNeLq/4gaXQk7yEddjoCpN/cWsVjX8NxZFsRLs00Ag89+NAbgWkr2eejKcXB+I4TZHVee8IPKdEh8ga6RtDD8GV9VpwhnOpDHT5K1CtuX2CyTMl8fgUxobZ4kauiRr4dChd5n9Bgp7mvTarl7k2nVXptSJDmaPvZ0ETht+WF24+a/7XqV7fyHoYU/WOvEGPW34a7X8R5UJWaOwZTcpqmfp8iwapRtgvQoXAISy2wK20fS0nK79nlqnhp5KEddTElMCMGCSqGSIb3DQEJFTEWBBTsd3zCMw1XrWC/MBjgt8IbFbCL8jAxMCEwCQYFKw4DAhoFAAQUY8Q/ANtHMzVyl4asrQ/lPKRjd2AECOBKL60N+UaKAgIIAA==",
+                "SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE="
             ],
             "_justification": "Secret used by test code, it is fake."
         },

sdk/core/azure-core/tests/test_basic_transport.py

@@ -79,7 +79,7 @@ def test_http_request_serialization(http_request):
         # Use OrderedDict to get consistent test result on 3.5 where order is not guaranteed
         headers=OrderedDict({
             "x-ms-date": "Thu, 14 Jun 2018 16:46:54 GMT",
-            "Authorization": "SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=",
+            "Authorization": "SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=", # fake key suppressed in credscan
             "Content-Length": "0",
         })
     )
@@ -88,7 +88,7 @@ def test_http_request_serialization(http_request):
     expected = (
         b'DELETE /container0/blob0 HTTP/1.1\r\n'
         b'x-ms-date: Thu, 14 Jun 2018 16:46:54 GMT\r\n'
-        b'Authorization: SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=\r\n'
+        b'Authorization: SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=\r\n' # fake key suppressed in credscan
         b'Content-Length: 0\r\n'
         b'\r\n'
     )

sdk/core/azure-core/tests/test_rest_http_request.py

@@ -355,7 +355,7 @@ def on_request(self, request):
             # modify header to know we entered this callback
             request.http_request.headers = {
                 "x-ms-date": "Thu, 14 Jun 2018 16:46:54 GMT",
-                "Authorization": "SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=",
+                "Authorization": "SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=", # fake key suppressed in credscan
                 "Content-Length": "0",
             }
 
@@ -367,7 +367,7 @@ def on_request(self, request):
             expected = (
                 b'DELETE http://localhost:5000/container0/blob0 HTTP/1.1\r\n'
                 b'x-ms-date: Thu, 14 Jun 2018 16:46:54 GMT\r\n'
-                b'Authorization: SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=\r\n'
+                b'Authorization: SharedKey account:G4jjBXA7LI/RnWKIOQ8i9xH4p76pAQ+4Fs4R1VxasaE=\r\n' # fake key suppressed in credscan
                 b'Content-Length: 0\r\n'
                 b'\r\n'
             )