[Communication] - Extract Identity Package out of Administration Package (Azure#16300)

* initial commit: new folder for identity

* Added root files to identity package

* copy identity client files from admin to new pkg

* add autorest generated files

* copy samples over

* update references in other packages

* Added tests to identity package

* remove identity code from admin package

* update changelog

* remove identity code from admin package

* update changelog

* Removed identity tests from admin package

* Update admin readme

* add back version.py for wheel generation

* Removed user credential test in admin package

* update _version.py

* remove redundant files

* fixed error with init file

* minor naming fixes

* only expose required shared models

* Update chat to reference new identity package

* Updated identity test recordings

* Added examples to identity README.md

* Updated dependencies in identity package

* Updated code style to meet pylint requirements

* Added identity package to ci file

* Updated CHANGELOG version formatting

Co-authored-by: Bert Ong <823691+beltr0n@users.noreply.github.com>

Author: lsundaralingam

sdk/communication/azure-communication-administration/CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 1.0.0b4 (Unreleased)
 
 ### Breaking Changes
+- CommunicationIdentityClient is moved to a new package: "azure.communication.identity"
 
 ##### `PhoneNumberAdministrationClient`
 -  `begin_reserve_phone_numbers` now takes `display_name`, `description`, `phone_plan_ids`, 

sdk/communication/azure-communication-administration/README.md

@@ -2,7 +2,7 @@
 
 # Azure Communication Administration Package client library for Python
 
-Azure Communication Administration client package is intended to be used to setup the basics for opening a way to use Azure Communication Service offerings. This package helps to create identities user tokens to be used by other client packages such as chat, calling, sms. 
+Azure Communication Administration client package is used to administer Phone Numbers. 
 
 # Getting started
 ### Prerequisites
@@ -17,31 +17,6 @@ pip install azure-communication-administration
 ```
 
 # Key concepts
-## CommunicationIdentityClient
-`CommunicationIdentityClient` provides operations for:
-
-- Create/delete identities to be used in Azure Communication Services. Those identities can be used to make use of Azure Communication offerings and can be scoped to have limited abilities through token scopes.
-
-- Create/revoke scoped user access tokens to access services such as chat, calling, sms. Tokens are issued for a valid Azure Communication identity and can be revoked at any time.
-
-### Initializing Identity Client
-```python
-# You can find your endpoint and access token from your resource in the Azure Portal
-import os
-from azure.communication.administration import CommunicationIdentityClient
-from azure.identity import DefaultAzureCredential
-
-connection_str = os.getenv('AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING')
-endpoint = os.getenv('AZURE_COMMUNICATION_SERVICE_ENDPOINT')
-
-# To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have
-# AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET as env variables.
-identity_client_managed_identity = CommunicationIdentityClient.(endpoint, DefaultAzureCredential())
-
-#You can also authenticate using your connection string
-identity_client = CommunicationIdentityClient.from_connection_string(connection_str)
-
-```
 
 ## CommunicationPhoneNumberClient
 ### Initializing Phone Number Client
@@ -70,10 +45,6 @@ Phone numbers can be assigned to a callback URL via the configure number API. As
 # Examples
 The following section provides several code snippets covering some of the most common Azure Communication Services tasks, including:
 
-[Create/delete Azure Communication Service identities][identitysamples] 
-
-[Create/revoke scoped user access tokens][identitysamples]
-
 ## Communication Phone number
 ### Get Countries
 
@@ -179,12 +150,12 @@ poller = phone_number_administration_client.begin_purchase_reservation(
 ```
 
 # Troubleshooting
-The Azure Communication Service Identity client will raise exceptions defined in [Azure Core][azure_core].
+The Phone Number Administration client will raise exceptions defined in [Azure Core][azure_core].
 
 # Next steps
 ## More sample code
 
-Please take a look at the [samples](https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/communication/azure-communication-administration/samples) directory for detailed examples of how to use this library to manage identities and tokens.
+Please take a look at the [samples](https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/communication/azure-communication-administration/samples) directory for detailed examples of how to use this library.
 
 ## Provide Feedback
 
@@ -201,5 +172,4 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
 For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
 
 <!-- LINKS -->
-[identitysamples]: https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/communication/azure-communication-administration/samples/identity_samples.py
 [azure_core]: https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/core/azure-core/README.md

sdk/communication/azure-communication-administration/azure/communication/administration/__init__.py

@@ -4,15 +4,9 @@
 # license information.
 # --------------------------------------------------------------------------
 
-from ._communication_identity_client import CommunicationIdentityClient
 from ._phone_number_administration_client import PhoneNumberAdministrationClient
 from ._polling import ReservePhoneNumberPolling, PurchaseReservationPolling, ReleasePhoneNumberPolling
 
-from ._identity._generated.models import (
-    CommunicationTokenRequest,
-    CommunicationIdentityToken
-)
-
 from ._phonenumber._generated.models import (
     AcquiredPhoneNumber,
     AcquiredPhoneNumbers,
@@ -42,16 +36,11 @@
 )
 
 __all__ = [
-    'CommunicationIdentityClient',
     'PhoneNumberAdministrationClient',
     'ReservePhoneNumberPolling',
     'PurchaseReservationPolling',
     'ReleasePhoneNumberPolling',
 
-    # from _identity
-    'CommunicationTokenRequest',
-    'CommunicationIdentityToken',
-
     # from _phonenumber
     'AcquiredPhoneNumber',
     'AcquiredPhoneNumbers',

sdk/communication/azure-communication-administration/azure/communication/administration/_identity/__init__.py

@@ -1,11 +1,9 @@
-from ._communication_identity_client_async import CommunicationIdentityClient
 from ._phone_number_administration_client_async import PhoneNumberAdministrationClient
 from ._polling_async import ReservePhoneNumberPollingAsync, \
     PurchaseReservationPollingAsync, \
     ReleasePhoneNumberPollingAsync
 
 __all__ = [
-    'CommunicationIdentityClient',
     'PhoneNumberAdministrationClient',
     'ReservePhoneNumberPollingAsync',
     'PurchaseReservationPollingAsync',

sdk/communication/azure-communication-administration/azure/communication/administration/aio/__init__.py

@@ -4,7 +4,7 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 # ------------------------------------
-from typing import Dict, List
+from typing import Dict
 
 from azure.communication.administration._phonenumber._generated.models import ReleaseStatus, CreateSearchOptions
 from azure.core.async_paging import AsyncItemPaged

sdk/communication/azure-communication-administration/azure/communication/administration/aio/_phone_number_administration_client_async.py

@@ -22,14 +22,14 @@ pip install --pre azure-communication-chat
 
 ## User Access Tokens
 
-User access tokens enable you to build client applications that directly authenticate to Azure Communication Services. You can generate these tokens with azure.communication.administration module, and then use them to initialize the Communication Services SDKs. Example of using azure.communication.administration:
+User access tokens enable you to build client applications that directly authenticate to Azure Communication Services. You can generate these tokens with azure.communication.identity module, and then use them to initialize the Communication Services SDKs. Example of using azure.communication.identity:
 
 ```bash
-pip install --pre azure-communication-administration
+pip install --pre azure-communication-identity
 ```
 
 ```python
-from azure.communication.administration import CommunicationIdentityClient
+from azure.communication.identity import CommunicationIdentityClient
 identity_client = CommunicationIdentityClient.from_connection_string("<connection string of your Communication service>")
 user = identity_client.create_user()
 tokenresponse = identity_client.issue_token(user, scopes=["chat"])
@@ -374,7 +374,7 @@ to create a resource, then set some Environment Variables
 set AZURE_COMMUNICATION_SERVICE_ENDPOINT="https://<RESOURCE_NAME>.communcationservices.azure.com"
 set AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING="<connection string of your Communication service>"
 
-pip install azure-communication-administration
+pip install azure-communication-identity
 
 python samples\chat_client_sample.py
 python samples\chat_client_sample_async.py

sdk/communication/azure-communication-chat/README.md

@@ -1,5 +1,5 @@
 -e ../../../tools/azure-devtools
 -e ../../../tools/azure-sdk-tools
 ../azure-communication-nspkg
--e ../azure-communication-administration
-aiohttp>=3.0; python_version >= '3.5'
+-e ../azure-communication-identity
+aiohttp>=3.0; python_version >= '3.5'

sdk/communication/azure-communication-chat/dev_requirements.txt

@@ -27,7 +27,7 @@
 
 
 class ChatClientSamples(object):
-    from azure.communication.administration import CommunicationIdentityClient
+    from azure.communication.identity import CommunicationIdentityClient
     connection_string = os.environ.get("AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING", None)
     if not connection_string:
         raise ValueError("Set AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING env before run this sample.")

sdk/communication/azure-communication-chat/samples/chat_client_sample.py

@@ -27,7 +27,7 @@
 
 
 class ChatClientSamplesAsync(object):
-    from azure.communication.administration import CommunicationIdentityClient
+    from azure.communication.identity import CommunicationIdentityClient
     connection_string = os.environ.get("AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING", None)
     if not connection_string:
         raise ValueError("Set AZURE_COMMUNICATION_SERVICE_CONNECTION_STRING env before run this sample.")