Support skipping recording (Azure#26847)

JoshLove-msft · web-flow · commit f6945ef21baf · 2022-02-08T12:24:56.000-08:00
* Support skipping recording

* Re-migrate form recognizer
diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
@@ -265,7 +265,7 @@
   </ItemGroup>
 
   <PropertyGroup>
-    <TestProxyVersion>1.0.0-dev.20220202.2</TestProxyVersion>
+    <TestProxyVersion>1.0.0-dev.20220207.4</TestProxyVersion>
   </PropertyGroup>
 
 </Project>
diff --git a/sdk/core/Azure.Core.TestFramework/src/ProxyTransport.cs b/sdk/core/Azure.Core.TestFramework/src/ProxyTransport.cs
@@ -118,10 +118,11 @@ private void RedirectToTestProxy(HttpMessage message)
                     case EntryRecordModel.Record:
                         break;
                     case EntryRecordModel.RecordWithoutRequestBody:
-                        message.Request.Content = null;
+                        message.Request.Headers.Add("x-recording-skip", "request-body");
                         break;
                     case EntryRecordModel.DoNotRecord:
-                        return;
+                        message.Request.Headers.Add("x-recording-skip", "request-response");
+                        break;
                 }
             }
             else if (_recording.Mode == RecordedTestMode.Playback)
diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/tests/Infrastructure/DocumentAnalysisLiveTestBase.cs b/sdk/formrecognizer/Azure.AI.FormRecognizer/tests/Infrastructure/DocumentAnalysisLiveTestBase.cs
@@ -19,7 +19,7 @@ public class DocumentAnalysisLiveTestBase : RecordedTestBase<DocumentAnalysisTes
         private readonly DocumentAnalysisClientOptions.ServiceVersion _serviceVersion;
 
         public DocumentAnalysisLiveTestBase(bool isAsync, DocumentAnalysisClientOptions.ServiceVersion serviceVersion)
-            : base(isAsync, useLegacyTransport: true)
+            : base(isAsync)
         {
             _serviceVersion = serviceVersion;
             Sanitizer = new DocumentAnalysisRecordedTestSanitizer();
diff --git a/sdk/formrecognizer/Azure.AI.FormRecognizer/tests/Infrastructure/FormRecognizerLiveTestBase.cs b/sdk/formrecognizer/Azure.AI.FormRecognizer/tests/Infrastructure/FormRecognizerLiveTestBase.cs
@@ -24,7 +24,7 @@ public class FormRecognizerLiveTestBase : RecordedTestBase<FormRecognizerTestEnv
         private readonly FormRecognizerClientOptions.ServiceVersion _serviceVersion;
 
         public FormRecognizerLiveTestBase(bool isAsync, FormRecognizerClientOptions.ServiceVersion serviceVersion)
-            : base(isAsync, useLegacyTransport: true)
+            : base(isAsync)
         {
             _serviceVersion = serviceVersion;
             Sanitizer = new FormRecognizerRecordedTestSanitizer();

Original file line number	Diff line number	Diff line change
`@@ -118,10 +118,11 @@ private void RedirectToTestProxy(HttpMessage message)`
`118`	`118`	`case EntryRecordModel.Record:`
`119`	`119`	`break;`
`120`	`120`	`case EntryRecordModel.RecordWithoutRequestBody:`
`121`		`- message.Request.Content = null;`
	`121`	`+ message.Request.Headers.Add("x-recording-skip", "request-body");`
`122`	`122`	`break;`
`123`	`123`	`case EntryRecordModel.DoNotRecord:`
`124`		`- return;`
	`124`	`+ message.Request.Headers.Add("x-recording-skip", "request-response");`
	`125`	`+ break;`
`125`	`126`	`}`
`126`	`127`	`}`
`127`	`128`	`else if (_recording.Mode == RecordedTestMode.Playback)`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public class DocumentAnalysisLiveTestBase : RecordedTestBase<DocumentAnalysisTes`
`19`	`19`	`private readonly DocumentAnalysisClientOptions.ServiceVersion _serviceVersion;`
`20`	`20`
`21`	`21`	`public DocumentAnalysisLiveTestBase(bool isAsync, DocumentAnalysisClientOptions.ServiceVersion serviceVersion)`
`22`		`- : base(isAsync, useLegacyTransport: true)`
	`22`	`+ : base(isAsync)`
`23`	`23`	`{`
`24`	`24`	`_serviceVersion = serviceVersion;`
`25`	`25`	`Sanitizer = new DocumentAnalysisRecordedTestSanitizer();`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public class FormRecognizerLiveTestBase : RecordedTestBase<FormRecognizerTestEnv`
`24`	`24`	`private readonly FormRecognizerClientOptions.ServiceVersion _serviceVersion;`
`25`	`25`
`26`	`26`	`public FormRecognizerLiveTestBase(bool isAsync, FormRecognizerClientOptions.ServiceVersion serviceVersion)`
`27`		`- : base(isAsync, useLegacyTransport: true)`
	`27`	`+ : base(isAsync)`
`28`	`28`	`{`
`29`	`29`	`_serviceVersion = serviceVersion;`
`30`	`30`	`Sanitizer = new FormRecognizerRecordedTestSanitizer();`