Skip to content

Commit f31dae5

Browse files
authored
[TA] Fix not passing domain=phi in sync and analyze endpoint plus some analyze cleanup (Azure#19104)
* fix in sync and analyze endpoint plus some analyze cleanup * remove transform
1 parent 624d630 commit f31dae5

File tree

58 files changed

+22764
-14014
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+22764
-14014
lines changed

sdk/textanalytics/Azure.AI.TextAnalytics/CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99
- Renamed `MinedOpinion` to `SentenceOpinion`.
1010
- Renamed `OpinionSentiment` to `AssessmentSentiment`.
1111
- For `PiiEntity.Category` the type of the property is now `PiiEntityCategory` instead of `EntityCategory`.
12-
12+
- `RecognizePiiEntitiesOptions.Domain` is now a nullable type.
13+
14+
### Fixes
15+
- `RecognizePiiEntities` and `TextAnalyticsActions.RecognizePiiEntitiesOptions` were always passing `PiiEntityDomainType.PHI`. Now, it is only passed when requested by the user [19086](https://github.com/Azure/azure-sdk-for-net/issues/19086).
16+
1317
## 5.1.0-beta.4 (2021-02-10)
1418
### New features
1519
- Added property `Length` to `CategorizedEntity`, `SentenceSentiment`, `LinkedEntityMatch`, `AspectSentiment`, `OpinionSentiment`, and `PiiEntity`.

sdk/textanalytics/Azure.AI.TextAnalytics/api/Azure.AI.TextAnalytics.netstandard2.0.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ public partial class RecognizePiiEntitiesOptions : Azure.AI.TextAnalytics.TextAn
534534
{
535535
public RecognizePiiEntitiesOptions() { }
536536
public System.Collections.Generic.IList<Azure.AI.TextAnalytics.PiiEntityCategory> CategoriesFilter { get { throw null; } }
537-
public Azure.AI.TextAnalytics.PiiEntityDomainType DomainFilter { get { throw null; } set { } }
537+
public Azure.AI.TextAnalytics.PiiEntityDomainType? DomainFilter { get { throw null; } set { } }
538538
}
539539
public partial class RecognizePiiEntitiesResult : Azure.AI.TextAnalytics.TextAnalyticsResult
540540
{

sdk/textanalytics/Azure.AI.TextAnalytics/src/EntitiesTask.cs

Lines changed: 0 additions & 20 deletions
This file was deleted.
Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,13 @@
11
// Copyright (c) Microsoft Corporation. All rights reserved.
22
// Licensed under the MIT License.
33

4-
using Azure.AI.TextAnalytics.Models;
54
using Azure.Core;
65

7-
namespace Azure.AI.TextAnalytics
6+
namespace Azure.AI.TextAnalytics.Models
87
{
98
/// <summary>
109
/// EntitiesTaskParameters class.
1110
/// </summary>
1211
[CodeGenModel("EntitiesTaskParameters")]
13-
internal partial class EntitiesTaskParameters
14-
{
15-
/// <summary>
16-
/// ModelVersion
17-
/// </summary>
18-
public string ModelVersion { get; set; } = "latest";
19-
20-
/// <summary>
21-
/// StringIndexType
22-
/// </summary>
23-
public StringIndexType StringIndexType { get; set; } = StringIndexType.Utf16CodeUnit;
24-
}
12+
internal partial class EntitiesTaskParameters { }
2513
}

sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/Models/EntitiesTask.Serialization.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/Models/EntitiesTask.cs

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/Models/EntitiesTaskParameters.Serialization.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/Models/EntitiesTaskParameters.cs

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/Models/KeyPhrasesTask.Serialization.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/textanalytics/Azure.AI.TextAnalytics/src/Generated/Models/KeyPhrasesTask.cs

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)