Fixed bug where Blob CopyFromUriOperation throws exception when statu… (Azure#27711)

Author: amnguye

sdk/storage/Azure.Storage.Blobs/CHANGELOG.md

@@ -4,6 +4,7 @@
 - Added support for service version 2021-06-08.
 - Added pageable versions of PageBlobClient.GetPageRanges() and .GetPageRangesAsync().
 - Added ability to copy source blob tags for BlobBaseClient.SyncCopyFromUri() and .SyncCopyFromUriAsync().
+- Fixed a bug where CopyFromUriOperation was throwing an Exception when the status of the blob copy was aborted or failed.
 
 ## 12.11.0 (2022-03-10)
 - Includes all features from 12.11.0-beta.1, 12.11.0-beta.2, and 12.11.0-beta.3 except SDK-calculated transactional checksums on data transfer.

sdk/storage/Azure.Storage.Blobs/src/Models/CopyFromUriOperation.cs

@@ -185,6 +185,13 @@ private async Task<Response> UpdateStatusAsync(bool async, CancellationToken can
             {
                 _value = update.Value.ContentLength;
             }
+            // Check if the operation aborted or failed
+            if (Id == update.Value.CopyId &&
+                (update.Value.CopyStatus == CopyStatus.Aborted ||
+                update.Value.CopyStatus == CopyStatus.Failed))
+            {
+                _value = 0;
+            }
 
             // Save this update as the latest raw response indicating the state
             // of the copy operation

sdk/storage/Azure.Storage.Blobs/tests/BlobBaseClientTests.cs

@@ -2303,6 +2303,48 @@ public async Task StartCopyFromUriAsync_VersionId()
             Assert.IsTrue(operation.GetRawResponse().Headers.TryGetValue(Constants.HeaderNames.VersionId, out var _));
         }
 
+        [RecordedTest]
+        public async Task StartCopyFromUriAsync_OperationAbort()
+        {
+            await using DisposingContainer test = await GetTestContainerAsync();
+
+            // Arrange
+            await test.Container.SetAccessPolicyAsync(PublicAccessType.Blob);
+            var data = GetRandomBuffer(8 * Constants.MB);
+
+            BlockBlobClient srcBlob = InstrumentClient(test.Container.GetBlockBlobClient(GetNewBlobName()));
+            using (var stream = new MemoryStream(data))
+            {
+                await srcBlob.UploadAsync(stream);
+            }
+
+            BlobServiceClient secondaryService = BlobsClientBuilder.GetServiceClient_SecondaryAccount_SharedKey();
+            await using DisposingContainer destTest = await GetTestContainerAsync(service: secondaryService);
+            {
+                BlockBlobClient destBlob = InstrumentClient(destTest.Container.GetBlockBlobClient(GetNewBlobName()));
+
+                CopyFromUriOperation operation = await destBlob.StartCopyFromUriAsync(srcBlob.Uri);
+
+                // Act
+                try
+                {
+                    Response response = await destBlob.AbortCopyFromUriAsync(operation.Id);
+
+                    // Act
+                    await operation.WaitForCompletionAsync();
+
+                    // Assert
+                    Assert.AreEqual(operation.Value,0);
+                    Assert.True(operation.HasCompleted);
+                    Assert.IsNotNull(operation.GetRawResponse());
+                }
+                catch (RequestFailedException e) when (e.ErrorCode == "NoPendingCopyOperation")
+                {
+                    WarnCopyCompletedTooQuickly();
+                }
+            }
+        }
+
         [RecordedTest]
         public async Task AbortCopyFromUriAsync()
         {