Flip JsonDateTokens sanitizer condition (Azure#16605)

Author: pakrym

sdk/anomalydetector/Azure.AI.AnomalyDetector/tests/Infrastructure/AnomalyDetectorRecordedTestSanitizer.cs

@@ -13,6 +13,8 @@ public AnomalyDetectorRecordedTestSanitizer()
         {
             JsonPathSanitizers.Add("$..accessToken");
             JsonPathSanitizers.Add("$..source");
+            // TODO: Remove when re-recording
+            LegacyConvertJsonDateTokens = true;
         }
 
         public override void SanitizeHeaders(IDictionary<string, string[]> headers)

sdk/communication/Azure.Communication.Administration/tests/Infrastructure/CommunicationIdentityClientRecordedTestSanitizer.cs

@@ -17,6 +17,8 @@ public CommunicationIdentityClientRecordedTestSanitizer(): base()
         {
             JsonPathSanitizers.Add("$..token");
             JsonPathSanitizers.Add("$..id");
+            // TODO: Remove when re-recording
+            LegacyConvertJsonDateTokens = true;
         }
 
         public override void SanitizeHeaders(IDictionary<string, string[]> headers)

sdk/core/Azure.Core.TestFramework/src/RecordedTestSanitizer.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using System;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
@@ -20,10 +21,15 @@ public class RecordedTestSanitizer
         //  when updating the JsonPathSanitizer logic to avoid changing date formats when deserializing requests.
         //  this property will be removed in the future.
         /// </summary>
-        public bool DoNotConvertJsonDateTokens { get; set; }
+        public bool LegacyConvertJsonDateTokens { get; set; }
 
         private static readonly string[] s_sanitizeValueArray = { SanitizeValue };
 
+        private static readonly JsonSerializerSettings SerializerSettings = new JsonSerializerSettings
+        {
+            DateParseHandling = DateParseHandling.None
+        };
+
         public List<string> SanitizedHeaders { get; } = new List<string> { "Authorization" };
 
         public virtual string SanitizeUri(string uri)
@@ -48,17 +54,12 @@ public virtual string SanitizeTextBody(string contentType, string body)
                 return body;
             try
             {
-                var settings = new JsonSerializerSettings
-                {
-                    DateParseHandling = DateParseHandling.None
-                };
-
                 JToken jsonO;
                 // Prevent default behavior where JSON.NET will convert DateTimeOffset
                 // into a DateTime.
-                if (DoNotConvertJsonDateTokens)
+                if (!LegacyConvertJsonDateTokens)
                 {
-                    jsonO = JsonConvert.DeserializeObject<JToken>(body, settings);
+                    jsonO = JsonConvert.DeserializeObject<JToken>(body, SerializerSettings);
                 }
                 else
                 {
@@ -72,7 +73,7 @@ public virtual string SanitizeTextBody(string contentType, string body)
                         token.Replace(JToken.FromObject(SanitizeValue));
                     }
                 }
-                return JsonConvert.SerializeObject(jsonO, settings);
+                return JsonConvert.SerializeObject(jsonO, SerializerSettings);
             }
             catch
             {

sdk/eventgrid/Azure.Messaging.EventGrid/tests/Infrastructure/EventGridLiveTestBase.cs

@@ -13,7 +13,6 @@ public EventGridLiveTestBase(bool isAsync) : base(isAsync/*, RecordedTestMode.Re
             Sanitizer.SanitizedHeaders.Add(Constants.SasKeyName);
             Sanitizer.SanitizedHeaders.Add(Constants.SasTokenName);
             Sanitizer.JsonPathSanitizers.Add("$..traceparent");
-            Sanitizer.DoNotConvertJsonDateTokens = true;
         }
     }
 }

sdk/iot/Azure.Iot.Hub.Service/tests/CustomRequestSanitizer.cs

@@ -22,6 +22,8 @@ public CustomRequestSanitizer()
             JsonPathSanitizers.Add("inputBlobContainerUri");
             JsonPathSanitizers.Add("..primaryKey");
             JsonPathSanitizers.Add("..secondaryKey");
+            // TODO: Remove when re-recording
+            LegacyConvertJsonDateTokens = true;
         }
 
         public override string SanitizeUri(string uri)

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/MetricsAdvisorRecordedTestSanitizer.cs

@@ -18,6 +18,8 @@ public MetricsAdvisorRecordedTestSanitizer()
             JsonPathSanitizers.Add("$..accountKey");
             JsonPathSanitizers.Add("$..authHeader");
             JsonPathSanitizers.Add("$..httpHeader");
+            // TODO: Remove when re-recording
+            LegacyConvertJsonDateTokens = true;
         }
 
         public override string SanitizeTextBody(string contentType, string body)