Fix SystemData and v1 ErrorResponse, remove PropertyReferenceType for ProviderResourceType (Azure#23472)

Author: fengzhou-msft

sdk/resourcemanager/Azure.ResourceManager/api/Azure.ResourceManager.netstandard2.0.cs

@@ -1463,12 +1463,12 @@ public SystemAssignedIdentity(System.Guid tenantId, System.Guid principalId) { }
     public partial class SystemData
     {
         public SystemData() { }
-        public System.DateTimeOffset? CreatedAt { get { throw null; } set { } }
-        public string CreatedBy { get { throw null; } set { } }
-        public Azure.ResourceManager.Resources.Models.CreatedByType? CreatedByType { get { throw null; } set { } }
-        public System.DateTimeOffset? LastModifiedAt { get { throw null; } set { } }
-        public string LastModifiedBy { get { throw null; } set { } }
-        public Azure.ResourceManager.Resources.Models.CreatedByType? LastModifiedByType { get { throw null; } set { } }
+        public System.DateTimeOffset? CreatedAt { get { throw null; } }
+        public string CreatedBy { get { throw null; } }
+        public Azure.ResourceManager.Resources.Models.CreatedByType? CreatedByType { get { throw null; } }
+        public System.DateTimeOffset? LastModifiedAt { get { throw null; } }
+        public string LastModifiedBy { get { throw null; } }
+        public Azure.ResourceManager.Resources.Models.CreatedByType? LastModifiedByType { get { throw null; } }
     }
     public partial class Tag : Azure.ResourceManager.Resources.Models.Resource
     {

sdk/resourcemanager/Azure.ResourceManager/src/Generated/Models/SystemData.Serialization.cs

@@ -5,15 +5,12 @@
 
 #nullable disable
 
-using System;
 using System.Collections.Generic;
 using System.Text.Json;
-using System.Text.Json.Serialization;
 using Azure.Core;
 
 namespace Azure.ResourceManager.Resources.Models
 {
-    [JsonConverter(typeof(ProviderResourceTypeConverter))]
     public partial class ProviderResourceType
     {
         internal static ProviderResourceType DeserializeProviderResourceType(JsonElement element)
@@ -137,18 +134,5 @@ internal static ProviderResourceType DeserializeProviderResourceType(JsonElement
             }
             return new ProviderResourceType(resourceType.Value, Optional.ToList(locations), Optional.ToList(locationMappings), Optional.ToList(aliases), Optional.ToList(apiVersions), defaultApiVersion.Value, Optional.ToList(apiProfiles), capabilities.Value, Optional.ToDictionary(properties));
         }
-
-        internal partial class ProviderResourceTypeConverter : JsonConverter<ProviderResourceType>
-        {
-            public override void Write(Utf8JsonWriter writer, ProviderResourceType providerResourceType, JsonSerializerOptions options)
-            {
-                writer.WriteObjectValue(providerResourceType);
-            }
-            public override ProviderResourceType Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-            {
-                using var document = JsonDocument.ParseValue(ref reader);
-                return DeserializeProviderResourceType(document.RootElement);
-            }
-        }
     }
 }

sdk/resourcemanager/Azure.ResourceManager/src/Generated/Models/SystemData.cs

@@ -7,16 +7,13 @@
 
 using System.Collections.Generic;
 using Azure.Core;
-using Azure.ResourceManager.Core;
 
 namespace Azure.ResourceManager.Resources.Models
 {
     /// <summary> Resource type managed by the resource provider. </summary>
-    [PropertyReferenceType]
     public partial class ProviderResourceType
     {
         /// <summary> Initializes a new instance of ProviderResourceType. </summary>
-        [InitializationConstructor]
         public ProviderResourceType()
         {
             Locations = new ChangeTrackingList<string>();
@@ -37,7 +34,6 @@ public ProviderResourceType()
         /// <param name="apiProfiles"> The API profiles for the resource provider. </param>
         /// <param name="capabilities"> The additional capabilities offered by this resource type. </param>
         /// <param name="properties"> The properties. </param>
-        [SerializationConstructor]
         internal ProviderResourceType(string resourceType, IReadOnlyList<string> locations, IReadOnlyList<ProviderExtendedLocation> locationMappings, IReadOnlyList<Alias> aliases, IReadOnlyList<string> apiVersions, string defaultApiVersion, IReadOnlyList<ApiProfile> apiProfiles, string capabilities, IReadOnlyDictionary<string, string> properties)
         {
             ResourceType = resourceType;

…ls/ProviderResourceType.Serialization.cs …ls/ProviderResourceType.Serialization.cssdk/resourcemanager/Azure.ResourceManager/src/Custom/Resources/Models/ProviderResourceType.Serialization.cs renamed to sdk/resourcemanager/Azure.ResourceManager/src/PsuedoGenerated/Resources/Models/ProviderResourceType.Serialization.cs sdk/resourcemanager/Azure.ResourceManager/src/Custom/Resources/Models/ProviderResourceType.Serialization.cs renamed to sdk/resourcemanager/Azure.ResourceManager/src/PsuedoGenerated/Resources/Models/ProviderResourceType.Serialization.cs

@@ -60,4 +60,8 @@ directive:
     where: $.definitions.*.properties[?(@.enum)]
     transform: >
       $["x-accessibility"] = "public"
+  - from: types.json
+    where: $.definitions.systemData.properties.*
+    transform: >
+      $["readOnly"] = true
 ```