Skip to content

Commit d9cc832

Browse files
m-nashazure-sdk
andauthored
Address archboard feedback (Azure#27478)
* temp changes to add in duplicate method for breaking change rename * rename Feature -> ArmFeature * rename Alias to ResourceTypeAlias * rename ParameterDefinitionsValue to ArmPolicyParameter * revert Feature rename since the resource suffix pr will fix it * update tests and api * align names with Azure.Identity * update api * update param name * remove custom NoWarn * Update AutoRest C# version to 3.0.0-beta.20220317.3 * address pr comments on related class renames * fix test references * remove duplicate api * suppress Alias in resources Co-authored-by: azure-sdk <azuresdk@microsoft.com>
1 parent 1c63b26 commit d9cc832

File tree

72 files changed

+1007
-954
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+1007
-954
lines changed

common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,22 +77,22 @@ private ArmEnvironment GetEnvironment(string endpoint)
7777
{
7878
if (string.IsNullOrEmpty(endpoint))
7979
{
80-
return ArmEnvironment.AzureCloud;
80+
return ArmEnvironment.AzurePublicCloud;
8181
}
8282

8383
var baseUri = new Uri(endpoint);
8484

85-
if (baseUri == ArmEnvironment.AzureCloud.BaseUri)
86-
return ArmEnvironment.AzureCloud;
85+
if (baseUri == ArmEnvironment.AzurePublicCloud.Endpoint)
86+
return ArmEnvironment.AzurePublicCloud;
8787

88-
if (baseUri == ArmEnvironment.AzureChinaCloud.BaseUri)
89-
return ArmEnvironment.AzureChinaCloud;
88+
if (baseUri == ArmEnvironment.AzureChina.Endpoint)
89+
return ArmEnvironment.AzureChina;
9090

91-
if (baseUri == ArmEnvironment.AzureGermanCloud.BaseUri)
92-
return ArmEnvironment.AzureGermanCloud;
91+
if (baseUri == ArmEnvironment.AzureGerman.Endpoint)
92+
return ArmEnvironment.AzureGerman;
9393

94-
if (baseUri == ArmEnvironment.AzureUSGovernment.BaseUri)
95-
return ArmEnvironment.AzureUSGovernment;
94+
if (baseUri == ArmEnvironment.AzureGovernment.Endpoint)
95+
return ArmEnvironment.AzureGovernment;
9696

9797
return new ArmEnvironment(new Uri(endpoint), TestEnvironment.ServiceManagementUrl ?? $"{endpoint}/.default");
9898
}

eng/Packages.Data.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@
152152
All should have PrivateAssets="All" set so they don't become package dependencies
153153
-->
154154
<ItemGroup>
155-
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20220317.1" PrivateAssets="All" />
155+
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20220317.3" PrivateAssets="All" />
156156
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20220111.2" PrivateAssets="All" />
157157
<PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
158158
<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />

sdk/appconfiguration/Azure.ResourceManager.AppConfiguration/src/Generated/Extensions/ArmClientExtensions.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/azurestackhci/Azure.ResourceManager.Hci/src/Generated/Extensions/ArmClientExtensions.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/cdn/Azure.ResourceManager.Cdn/src/Generated/Extensions/ArmClientExtensions.cs

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.ResourceManager.Communication/src/Generated/Extensions/ArmClientExtensions.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)